Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Issue 1195613003: Add d8 API for spawning function on a new thread (Second try) (Closed)

Created:
5 years, 6 months ago by binji
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add d8 API for spawning function on a new thread (Second try) This API closely matches the Worker API. The differences: 1) The argument to the Worker constructor is a function to run, not a script. 2) Receiving a message from a worker is a synchronous API (as there is no event loop). The serialization done here is not robust as the real DOM implementation. For example, recursive data structures or otherwise duplicated objects are not allowed. BUG=chromium:497295 R=jochen@chromium.org LOG=n Review URL: https://codereview.chromium.org/1185643004 Cr-Commit-Position: refs/heads/master@{#29126} Committed: https://crrev.com/ec2eaf712ecee6b4891c0458f2397e04a1f9b339 Cr-Commit-Position: refs/heads/master@{#29158}

Patch Set 1 #

Patch Set 2 : fixes for Shared + Arm builders #

Patch Set 3 : remove UnboundQueue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+857 lines, -7 lines) Patch
M src/d8.h View 1 2 6 chunks +122 lines, -0 lines 0 comments Download
M src/d8.cc View 1 2 11 chunks +601 lines, -7 lines 0 comments Download
A test/mjsunit/d8-worker.js View 1 1 chunk +134 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
binji
Reverted last change because it broke the shared builders + Arm builder. Patch #1 is ...
5 years, 6 months ago (2015-06-18 21:57:57 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-19 06:36:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195613003/60001
5 years, 6 months ago (2015-06-19 16:11:07 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 6 months ago (2015-06-19 16:13:02 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/ec2eaf712ecee6b4891c0458f2397e04a1f9b339 Cr-Commit-Position: refs/heads/master@{#29158}
5 years, 6 months ago (2015-06-19 16:13:18 UTC) #7
binji
5 years, 6 months ago (2015-06-19 18:31:44 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1191373005/ by binji@chromium.org.

The reason for reverting is: Fails on V8 Linux - isolates
(http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20isolates/buil...).

Powered by Google App Engine
This is Rietveld 408576698