Issue 1195573002: Make GrGLProgramDataManager not refcounted

Issue 1195573002: Make GrGLProgramDataManager not refcounted (Closed)

Created:
5 years, 6 months ago by Kimmo Kinnunen

Modified:
5 years, 6 months ago

Reviewers:
bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Make GrGLProgramDataManager not refcounted Make GrGLProgramDataManager not refcounted, refcounting is not used for the instances. Committed: https://skia.googlesource.com/skia/+/78cff136a4b59045e82965cbc9a63bf76a595796

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	src/gpu/gl/GrGLProgramDataManager.h	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Total messages: 8 (3 generated)

bsalomon

On 2015/06/18 11:01:02, Kimmo Kinnunen wrote: Can we make it inherit from SkNoncopyable? Otherwise, lgtm.

5 years, 6 months ago (2015-06-18 14:36:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195573002/20001

5 years, 6 months ago (2015-06-22 05:49:48 UTC) #6

commit-bot: I haz the power

The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...

5 years, 6 months ago (2015-06-22 05:49:48 UTC) #7

commit-bot: I haz the power

5 years, 6 months ago (2015-06-22 05:55:15 UTC) #8

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/78cff136a4b59045e82965cbc9a63bf76a595796