components/autofill/content/renderer/page_click_tracker.h - Issue 1195473005: Let PageClickTracker use onMouseDown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/page_click_tracker.h

Issue 1195473005: Let PageClickTracker use onMouseDown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/content/renderer/page_click_tracker.h

diff --git a/components/autofill/content/renderer/page_click_tracker.h b/components/autofill/content/renderer/page_click_tracker.h

index 0c6585af0111e446abaffcc0be322c29a9852ba3..eed10f9a810b2be3eff48b9819cba14882ce0057 100644

--- a/components/autofill/content/renderer/page_click_tracker.h

+++ b/components/autofill/content/renderer/page_click_tracker.h

@@ -42,8 +42,7 @@ class PageClickTracker : public content::RenderFrameObserver {

// RenderViewObserver implementation.

void OnDestruct() override;

- void DidHandleMouseEvent(const blink::WebMouseEvent& event) override;

- void DidHandleGestureEvent(const blink::WebGestureEvent& event) override;

+ void OnMouseDown(const blink::WebNode& mouse_down_node) override;

void FocusChangeComplete() override;

private:

@@ -56,8 +55,7 @@ class PageClickTracker : public content::RenderFrameObserver {

// RenderViewObserver methods forwarded from Legacy. Should be

// merged into RenderFrameObserver.

- void DidHandleMouseEvent(const blink::WebMouseEvent& event);

- void DidHandleGestureEvent(const blink::WebGestureEvent& event);

+ void OnMouseDown(const blink::WebNode& mouse_down_node);

void FocusChangeComplete();

void DoFocusChangeComplete();