Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(933)

Unified Diff: components/autofill/content/renderer/page_click_tracker.cc

Issue 1195473005: Let PageClickTracker use onMouseDown (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/content/renderer/page_click_tracker.cc
diff --git a/components/autofill/content/renderer/page_click_tracker.cc b/components/autofill/content/renderer/page_click_tracker.cc
index 8f1b0c211070051829239e9b6f4ad015d0b68ad7..193dd7aea88b023c6902f34bc7f3e63dc2492d73 100644
--- a/components/autofill/content/renderer/page_click_tracker.cc
+++ b/components/autofill/content/renderer/page_click_tracker.cc
@@ -74,28 +74,9 @@ PageClickTracker::PageClickTracker(content::RenderFrame* render_frame,
PageClickTracker::~PageClickTracker() {
}
-void PageClickTracker::DidHandleMouseEvent(const WebMouseEvent& event) {
- if (event.type != WebInputEvent::MouseDown ||
- event.button != WebMouseEvent::ButtonLeft) {
- return;
- }
-
- WebNode clicked_node = render_frame()->GetRenderView()->GetWebView()
- ->hitTestResultAt(WebPoint(event.x, event.y)).node();
- focused_node_was_last_clicked_ = !clicked_node.isNull() &&
- clicked_node.focused();
-}
-
-void PageClickTracker::DidHandleGestureEvent(const WebGestureEvent& event) {
- if (event.type != WebGestureEvent::GestureTap)
- return;
-
- WebNode tapped_node = render_frame()->GetRenderView()->GetWebView()
- ->hitTestResultForTap(
- WebPoint(event.x, event.y),
- WebSize(event.data.tap.width, event.data.tap.height)).node();
- focused_node_was_last_clicked_ = !tapped_node.isNull() &&
- tapped_node.focused();
+void PageClickTracker::OnMouseDown(const WebNode& mouse_down_node) {
+ focused_node_was_last_clicked_ = !mouse_down_node.isNull() &&
+ mouse_down_node.focused();
}
void PageClickTracker::FocusedNodeChanged(const WebNode& node) {
@@ -149,13 +130,8 @@ void PageClickTracker::Legacy::OnDestruct() {
// No-op. Don't delete |this|.
}
-void PageClickTracker::Legacy::DidHandleMouseEvent(const WebMouseEvent& event) {
- tracker_->DidHandleMouseEvent(event);
-}
-
-void PageClickTracker::Legacy::DidHandleGestureEvent(
- const WebGestureEvent& event) {
- tracker_->DidHandleGestureEvent(event);
+void PageClickTracker::Legacy::OnMouseDown(const WebNode& mouse_down_node) {
+ tracker_->OnMouseDown(mouse_down_node);
}
void PageClickTracker::Legacy::FocusChangeComplete() {
« no previous file with comments | « components/autofill/content/renderer/page_click_tracker.h ('k') | content/public/renderer/render_view_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698