Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 1195163007: Revert of [destructuring] Implement parameter pattern matching. (Closed)

Created:
5 years, 6 months ago by Michael Achenbach
Modified:
5 years, 6 months ago
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [destructuring] Implement parameter pattern matching. (patchset #7 id:120001 of https://codereview.chromium.org/1189743003/) Reason for revert: [Sheriff] Breaks tsan: http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/4392 Original issue's description: > [destructuring] Implement parameter pattern matching. > > Scoping for initializers is yet incorrect. Defaults are not supported. > > R=arv@chromium.org,rossberg@chromium.org > BUG=v8:811 > LOG=N > > Committed: https://crrev.com/42f30f4ded2b1ca0c4caa7639e6206e93c78ee70 > Cr-Commit-Position: refs/heads/master@{#29184} TBR=arv@chromium.org,rossberg@chromium.org,caitpotter88@gmail.com,wingo@igalia.com,dslomov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Committed: https://crrev.com/82e80605152f24c7ee1e738a0d1c890156ce038c Cr-Commit-Position: refs/heads/master@{#29188}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -446 lines) Patch
M src/parser.h View 11 chunks +28 lines, -77 lines 0 comments Download
M src/parser.cc View 21 chunks +47 lines, -94 lines 0 comments Download
M src/pattern-rewriter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/preparser.h View 25 chunks +57 lines, -99 lines 0 comments Download
M src/preparser.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M src/scopes.cc View 1 chunk +4 lines, -11 lines 0 comments Download
M test/cctest/test-parsing.cc View 3 chunks +1 line, -110 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 2 chunks +0 lines, -42 lines 0 comments Download
M test/mjsunit/regress/regress-1130.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-436896.js View 1 chunk +1 line, -1 line 0 comments Download
M test/webkit/fast/js/arguments-expected.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [destructuring] Implement parameter pattern matching.
5 years, 6 months ago (2015-06-22 13:13:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1195163007/1
5 years, 6 months ago (2015-06-22 13:14:03 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 13:14:21 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 13:14:33 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/82e80605152f24c7ee1e738a0d1c890156ce038c
Cr-Commit-Position: refs/heads/master@{#29188}

Powered by Google App Engine
This is Rietveld 408576698