Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1194943002: Inline SetLengthWithoutNormalize into its callers (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Inline SetLengthWithoutNormalize into its callers BUG= Committed: https://crrev.com/7028e4b531f805ebb2555a7606f5a16cc14b02e5 Cr-Commit-Position: refs/heads/master@{#29165}

Patch Set 1 #

Patch Set 2 : Only find last non-configurable element in dicts if it can be present #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -88 lines) Patch
M src/elements.cc View 1 4 chunks +48 lines, -87 lines 1 comment Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-19 15:27:14 UTC) #2
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-19 16:44:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194943002/20001
5 years, 6 months ago (2015-06-19 17:02:06 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 18:59:18 UTC) #6
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/7028e4b531f805ebb2555a7606f5a16cc14b02e5 Cr-Commit-Position: refs/heads/master@{#29165}
5 years, 6 months ago (2015-06-19 18:59:34 UTC) #7
brucedawson
https://codereview.chromium.org/1194943002/diff/20001/src/elements.cc File src/elements.cc (right): https://codereview.chromium.org/1194943002/diff/20001/src/elements.cc#newcode1323 src/elements.cc:1323: Isolate* isolate = array->GetIsolate(); This declaration of 'isolate' shadows ...
5 years, 6 months ago (2015-06-22 17:12:36 UTC) #9
Toon Verwaest
5 years, 6 months ago (2015-06-22 18:34:50 UTC) #10
Message was sent while issue was closed.
Will do so: https://codereview.chromium.org/1196533004

Powered by Google App Engine
This is Rietveld 408576698