Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1196533004: Remove duplicate isolate (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove duplicate isolate BUG= Committed: https://crrev.com/55a6a4977799f3c896d94db735f86be0052a8796 Cr-Commit-Position: refs/heads/master@{#29204}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/elements.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
Toon Verwaest
ptal
5 years, 6 months ago (2015-06-22 18:35:18 UTC) #2
brucedawson
I'm not an OWNER but lgtm.
5 years, 6 months ago (2015-06-22 18:41:37 UTC) #3
Jakob Kummerow
lgtm
5 years, 6 months ago (2015-06-22 18:52:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1196533004/1
5 years, 6 months ago (2015-06-22 19:32:21 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-22 19:57:51 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-22 19:58:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55a6a4977799f3c896d94db735f86be0052a8796
Cr-Commit-Position: refs/heads/master@{#29204}

Powered by Google App Engine
This is Rietveld 408576698