Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: fpdfsdk/src/fpdfppo.cpp

Issue 1194933003: Make CPDF_Object::GetString() a virtual method. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: fpdfsdk/src/fpdfppo.cpp
diff --git a/fpdfsdk/src/fpdfppo.cpp b/fpdfsdk/src/fpdfppo.cpp
index 21ae05d89fd90fbee58959f45bc019983df94b6c..c23cdd457b4c3e378524fc72fe248ac829b0c64e 100644
--- a/fpdfsdk/src/fpdfppo.cpp
+++ b/fpdfsdk/src/fpdfppo.cpp
@@ -53,7 +53,7 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document *pDestPDFDoc, CPDF_Document
DInfoDict->SetAt("Producer", new CPDF_String(producerstr));
//Set type////////////////////////////////////////////////////////////////
- CFX_ByteString cbRootType = pNewRoot->GetString("Type","");
+ CFX_ByteString cbRootType = pNewRoot->GetStringAt("Type", "");
if( cbRootType.Equal("") )
{
pNewRoot->SetAt("Type", new CPDF_Name("Catalog"));
@@ -67,7 +67,7 @@ FX_BOOL CPDF_PageOrganizer::PDFDocInit(CPDF_Document *pDestPDFDoc, CPDF_Document
pNewRoot->SetAt("Pages", new CPDF_Reference(pDestPDFDoc, NewPagesON));
}
- CFX_ByteString cbPageType = pNewPages->GetString("Type","");
+ CFX_ByteString cbPageType = pNewPages->GetStringAt("Type", "");
if(cbPageType.Equal(""))
{
pNewPages->SetAt("Type", new CPDF_Name("Pages"));
@@ -325,7 +325,8 @@ int CPDF_PageOrganizer::GetNewObjId(CPDF_Document *pDoc, CFX_MapPtrToPtr* pMapPt
CPDF_Dictionary* pDictClone = (CPDF_Dictionary*)pClone;
if(pDictClone->KeyExist("Type"))
{
- CFX_ByteString strType = pDictClone->GetString("Type");
+ CFX_ByteString strType =
+ pDictClone->GetStringAt("Type");
if(!FXSYS_stricmp(strType, "Pages"))
{
pDictClone->Release();

Powered by Google App Engine
This is Rietveld 408576698