fpdfsdk/src/fpdfdoc.cpp - Issue 1194933003: Make CPDF_Object::GetString() a virtual method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdfdoc.cpp

Issue 1194933003: Make CPDF_Object::GetString() a virtual method. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdfdoc.cpp

diff --git a/fpdfsdk/src/fpdfdoc.cpp b/fpdfsdk/src/fpdfdoc.cpp

index ca0c30ee1bb3298977380b13f74ebb6dbb40db2b..25788d794a57024695370918af69f3174bfd3ac9 100644

--- a/fpdfsdk/src/fpdfdoc.cpp

+++ b/fpdfsdk/src/fpdfdoc.cpp

@@ -219,7 +219,7 @@ DLLEXPORT FPDF_BOOL STDCALL FPDFLink_Enumerate(FPDF_PAGE page, int* startPos, FP

CPDF_Dictionary* pDict = (CPDF_Dictionary*)pAnnots->GetElementValue(i);

if (!pDict || pDict->GetType() != PDFOBJ_DICTIONARY)

continue;

- if(pDict->GetString(FX_BSTRC("Subtype")).Equal(FX_BSTRC("Link"))) {

+ if(pDict->GetStringAt("Subtype").Equal(FX_BSTRC("Link"))) {

*startPos = i + 1;

*linkAnnot = (FPDF_LINK)pDict;

return TRUE;