Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1948)

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 119493003: Remove a no-longer needed user gesture from WebFrameImpl::executeScriptAndReturnValue() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebFrameImpl.cpp
diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp
index 8bd58c8fd7c7afed4424ddc0835692b6b8c666c2..5522ff387ce0ea3671e7ff6686630730375c3c4a 100644
--- a/Source/web/WebFrameImpl.cpp
+++ b/Source/web/WebFrameImpl.cpp
@@ -843,13 +843,6 @@ bool WebFrameImpl::checkIfRunInsecureContent(const WebURL& url) const
v8::Handle<v8::Value> WebFrameImpl::executeScriptAndReturnValue(const WebScriptSource& source)
{
ASSERT(frame());
-
- // FIXME: This fake user gesture is required to make a bunch of pyauto
- // tests pass. If this isn't needed in non-test situations, we should
- // consider removing this code and changing the tests.
- // http://code.google.com/p/chromium/issues/detail?id=86397
- UserGestureIndicator gestureIndicator(DefinitelyProcessingNewUserGesture);
-
TextPosition position(OrdinalNumber::fromOneBasedInt(source.startLine), OrdinalNumber::first());
return frame()->script().executeScriptInMainWorldAndReturnValue(ScriptSourceCode(source.code, source.url, position)).v8Value();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698