Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1194863002: Fix the incorrect metric name in the Password Manager. (Closed)

Created:
5 years, 6 months ago by msramek
Modified:
5 years, 6 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, Ilya Sherman, mkwst+watchlist-passwords_chromium.org, vabr+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix the incorrect metric name in the Password Manager. OfferedToFillAndroidCredentials -> FillSuggestionsIncludeAndroidAppCredentials BUG=437865 Committed: https://crrev.com/da9cd3bbadd7a54b1722e6affdd0871e578bb5e2 Cr-Commit-Position: refs/heads/master@{#335251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M components/password_manager/core/browser/password_manager.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
msramek
Hi Václav, could you please have a quick look? In https://codereview.chromium.org/1182913004/, I changed the histogram ...
5 years, 6 months ago (2015-06-19 12:09:39 UTC) #2
Mike West
LGTM
5 years, 6 months ago (2015-06-19 12:12:53 UTC) #5
msramek
Thanks, Mike :)
5 years, 6 months ago (2015-06-19 12:15:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194863002/1
5 years, 6 months ago (2015-06-19 12:15:21 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-19 13:21:14 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/da9cd3bbadd7a54b1722e6affdd0871e578bb5e2 Cr-Commit-Position: refs/heads/master@{#335251}
5 years, 6 months ago (2015-06-19 13:22:02 UTC) #10
vabr (Chromium)
5 years, 6 months ago (2015-06-19 16:28:58 UTC) #11
Message was sent while issue was closed.
LGTM as well. :)

Powered by Google App Engine
This is Rietveld 408576698