Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: components/password_manager/core/browser/password_manager.cc

Issue 1194863002: Fix the incorrect metric name in the Password Manager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/password_manager/core/browser/password_manager.h" 5 #include "components/password_manager/core/browser/password_manager.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/metrics/field_trial.h" 8 #include "base/metrics/field_trial.h"
9 #include "base/metrics/histogram_macros.h" 9 #include "base/metrics/histogram_macros.h"
10 #include "base/prefs/pref_service.h" 10 #include "base/prefs/pref_service.h"
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 // schemed password form may have been freed, so we need to distinguish. 678 // schemed password form may have been freed, so we need to distinguish.
679 autofill::PasswordFormFillData fill_data; 679 autofill::PasswordFormFillData fill_data;
680 InitPasswordFormFillData(form_for_autofill, 680 InitPasswordFormFillData(form_for_autofill,
681 best_matches, 681 best_matches,
682 &preferred_match, 682 &preferred_match,
683 wait_for_username, 683 wait_for_username,
684 OtherPossibleUsernamesEnabled(), 684 OtherPossibleUsernamesEnabled(),
685 &fill_data); 685 &fill_data);
686 if (logger) 686 if (logger)
687 logger->LogBoolean(Logger::STRING_WAIT_FOR_USERNAME, wait_for_username); 687 logger->LogBoolean(Logger::STRING_WAIT_FOR_USERNAME, wait_for_username);
688 UMA_HISTOGRAM_BOOLEAN("PasswordManager.OfferedToFillAndroidCredentials", 688 UMA_HISTOGRAM_BOOLEAN(
689 ContainsAndroidCredentials(fill_data)); 689 "PasswordManager.FillSuggestionsIncludeAndroidAppCredentials",
690 ContainsAndroidCredentials(fill_data));
690 driver->FillPasswordForm(fill_data); 691 driver->FillPasswordForm(fill_data);
691 break; 692 break;
692 } 693 }
693 default: 694 default:
694 if (logger) { 695 if (logger) {
695 logger->LogBoolean(Logger::STRING_LOGINMODELOBSERVER_PRESENT, 696 logger->LogBoolean(Logger::STRING_LOGINMODELOBSERVER_PRESENT,
696 observers_.might_have_observers()); 697 observers_.might_have_observers());
697 } 698 }
698 FOR_EACH_OBSERVER( 699 FOR_EACH_OBSERVER(
699 LoginModelObserver, 700 LoginModelObserver,
(...skipping 20 matching lines...) Expand all
720 if (ServerTypeToPrediction((*field)->server_type(), &prediction_type)) 721 if (ServerTypeToPrediction((*field)->server_type(), &prediction_type))
721 predictions[form->ToFormData()][prediction_type] = *(*field); 722 predictions[form->ToFormData()][prediction_type] = *(*field);
722 } 723 }
723 } 724 }
724 if (predictions.empty()) 725 if (predictions.empty())
725 return; 726 return;
726 driver->AutofillDataReceived(predictions); 727 driver->AutofillDataReceived(predictions);
727 } 728 }
728 729
729 } // namespace password_manager 730 } // namespace password_manager
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698