Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Unified Diff: Source/core/frame/UseCounter.cpp

Issue 1194763002: Deprecate MediaStream label, ended attributes and stop() method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/UseCounter.cpp
diff --git a/Source/core/frame/UseCounter.cpp b/Source/core/frame/UseCounter.cpp
index 4be6424aa5c6e6fef62172fee654c8d23926633e..aa28b5ae4706f81c58d13d5d72bfa1588d744916 100644
--- a/Source/core/frame/UseCounter.cpp
+++ b/Source/core/frame/UseCounter.cpp
@@ -935,6 +935,13 @@ String UseCounter::deprecationMessage(Feature feature)
case SVGSMILAnimationInImageRegardlessOfCache:
return "SVG's SMIL animations (<animate>, <set>, etc.) are deprecated and will be removed. Please use CSS animations or Web animations instead.";
+ case MediaStreamLabel:
+ return "'MediaStream.label' is deprecated, please do not use it. as per spec (http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
Habib Virji 2015/06/23 08:58:21 Would suggest rewording this to: "'MediaStream.lab
shiva.jm 2015/06/24 09:59:30 Done.
+ case MediaStreamStop:
+ return "'MediaStream.stop()' is deprecated, after adding MediaStream.active attribute, please do not use it. as per spec (http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
Habib Virji 2015/06/23 08:58:21 "'MediaStream.stop()' is deprecated. Please use Me
shiva.jm 2015/06/24 09:59:30 Done.
+ case MediaStreamEnded:
+ return "'MediaStream.ended' is deprecated, after adding MediaStream.active attribute, please do not use it. as per spec (http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStream).";
Habib Virji 2015/06/23 08:58:21 Same as above comments.
shiva.jm 2015/06/24 09:59:30 Done.
+
// Features that aren't deprecated don't have a deprecation message.
default:
return String();

Powered by Google App Engine
This is Rietveld 408576698