Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: Source/core/frame/UseCounter.cpp

Issue 1194763002: Deprecate MediaStream label, ended attributes and stop() method (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 917 matching lines...) Expand 10 before | Expand all | Expand 10 after
928 case PrefixedMouseEventMovementY: 928 case PrefixedMouseEventMovementY:
929 return replacedBy("webkitMovementY", "movementY"); 929 return replacedBy("webkitMovementY", "movementY");
930 930
931 case VideoFullscreenAllowedExemption: 931 case VideoFullscreenAllowedExemption:
932 return "Entering fullscreen in an <iframe> with no allowfullscreen attri bute is deprecated and will stop working in M46, around October 2015. Please use the allowfullscreen attribute."; 932 return "Entering fullscreen in an <iframe> with no allowfullscreen attri bute is deprecated and will stop working in M46, around October 2015. Please use the allowfullscreen attribute.";
933 933
934 case SVGSMILElementInDocument: 934 case SVGSMILElementInDocument:
935 case SVGSMILAnimationInImageRegardlessOfCache: 935 case SVGSMILAnimationInImageRegardlessOfCache:
936 return "SVG's SMIL animations (<animate>, <set>, etc.) are deprecated an d will be removed. Please use CSS animations or Web animations instead."; 936 return "SVG's SMIL animations (<animate>, <set>, etc.) are deprecated an d will be removed. Please use CSS animations or Web animations instead.";
937 937
938 case MediaStreamLabel:
939 return "'MediaStream.label' is deprecated, please do not use it. as per spec (http://w3c.github.io/mediacapture-main/getusermedia.html#idl-def-MediaStre am).";
Habib Virji 2015/06/23 08:58:21 Would suggest rewording this to: "'MediaStream.lab
shiva.jm 2015/06/24 09:59:30 Done.
940 case MediaStreamStop:
941 return "'MediaStream.stop()' is deprecated, after adding MediaStream.act ive attribute, please do not use it. as per spec (http://w3c.github.io/mediacapt ure-main/getusermedia.html#idl-def-MediaStream).";
Habib Virji 2015/06/23 08:58:21 "'MediaStream.stop()' is deprecated. Please use Me
shiva.jm 2015/06/24 09:59:30 Done.
942 case MediaStreamEnded:
943 return "'MediaStream.ended' is deprecated, after adding MediaStream.acti ve attribute, please do not use it. as per spec (http://w3c.github.io/mediacaptu re-main/getusermedia.html#idl-def-MediaStream).";
Habib Virji 2015/06/23 08:58:21 Same as above comments.
shiva.jm 2015/06/24 09:59:30 Done.
944
938 // Features that aren't deprecated don't have a deprecation message. 945 // Features that aren't deprecated don't have a deprecation message.
939 default: 946 default:
940 return String(); 947 return String();
941 } 948 }
942 } 949 }
943 950
944 void UseCounter::count(CSSParserContext context, CSSPropertyID feature) 951 void UseCounter::count(CSSParserContext context, CSSPropertyID feature)
945 { 952 {
946 ASSERT(feature >= firstCSSProperty); 953 ASSERT(feature >= firstCSSProperty);
947 ASSERT(feature <= lastUnresolvedCSSProperty); 954 ASSERT(feature <= lastUnresolvedCSSProperty);
(...skipping 27 matching lines...) Expand all
975 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents) 982 UseCounter* UseCounter::getFrom(const StyleSheetContents* sheetContents)
976 { 983 {
977 // FIXME: We may want to handle stylesheets that have multiple owners 984 // FIXME: We may want to handle stylesheets that have multiple owners
978 // http://crbug.com/242125 985 // http://crbug.com/242125
979 if (sheetContents && sheetContents->hasSingleOwnerNode()) 986 if (sheetContents && sheetContents->hasSingleOwnerNode())
980 return getFrom(sheetContents->singleOwnerDocument()); 987 return getFrom(sheetContents->singleOwnerDocument());
981 return 0; 988 return 0;
982 } 989 }
983 990
984 } // namespace blink 991 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698