Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1194743002: cc: Remove ResourceUpdateQueue and ResourceUpdateController. (Closed)

Created:
5 years, 6 months ago by danakj
Modified:
5 years, 6 months ago
Reviewers:
jam, vmpstr, enne (OOO)
CC:
chromium-reviews, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Remove ResourceUpdateQueue and ResourceUpdateController. These classes are for uploading textures with non-impl-side painting, so don't use them anymore now. Also removes ResourceUpdate and the last ContentLayerUpdater that used it, which is all dead code now that TiledLayer is gone. R=enne, vmpstr TBR=jam BUG=413479 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/4dac85e8857e3adec857749c68a893e8f1448e7d Cr-Commit-Position: refs/heads/master@{#335287}

Patch Set 1 #

Patch Set 2 : resourcequeue: cc_blink #

Patch Set 3 : resourcequeue: build.gn #

Patch Set 4 : resourcequeue: layer_updater #

Patch Set 5 : resourcequeue: header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1197 lines) Patch
M cc/BUILD.gn View 1 2 2 chunks +0 lines, -13 lines 0 comments Download
M cc/blink/web_external_texture_layer_impl.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M cc/cc.gyp View 2 chunks +0 lines, -13 lines 0 comments Download
M cc/debug/micro_benchmark_controller_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/layer_perftest.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/layers/layer_unittest.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M cc/layers/nine_patch_layer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/layers/painted_scrollbar_layer.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/layers/ui_resource_layer.cc View 1 chunk +0 lines, -2 lines 0 comments Download
D cc/resources/bitmap_content_layer_updater.h View 1 chunk +0 lines, -78 lines 0 comments Download
D cc/resources/bitmap_content_layer_updater.cc View 1 chunk +0 lines, -107 lines 0 comments Download
D cc/resources/content_layer_updater.h View 1 chunk +0 lines, -66 lines 0 comments Download
D cc/resources/content_layer_updater.cc View 1 chunk +0 lines, -118 lines 0 comments Download
D cc/resources/layer_painter.h View 1 chunk +0 lines, -27 lines 0 comments Download
D cc/resources/layer_updater.h View 1 2 3 1 chunk +0 lines, -76 lines 0 comments Download
D cc/resources/layer_updater.cc View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
D cc/resources/resource_update.h View 1 chunk +0 lines, -37 lines 0 comments Download
D cc/resources/resource_update.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D cc/resources/resource_update_controller.h View 1 chunk +0 lines, -88 lines 0 comments Download
D cc/resources/resource_update_controller.cc View 1 chunk +0 lines, -163 lines 0 comments Download
D cc/resources/resource_update_queue.h View 1 chunk +0 lines, -43 lines 0 comments Download
D cc/resources/resource_update_queue.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M cc/scheduler/scheduler.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/scheduler/scheduler.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 6 chunks +0 lines, -81 lines 0 comments Download
M cc/test/fake_painted_scrollbar_layer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/test/fake_proxy.h View 2 chunks +0 lines, -3 lines 0 comments Download
M cc/test/fake_proxy.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M cc/trees/layer_tree_host.h View 2 chunks +0 lines, -7 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +0 lines, -26 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/trees/proxy.h View 1 chunk +0 lines, -3 lines 0 comments Download
M cc/trees/single_thread_proxy.h View 4 chunks +0 lines, -4 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 5 chunks +0 lines, -30 lines 0 comments Download
M cc/trees/thread_proxy.h View 6 chunks +3 lines, -14 lines 0 comments Download
M cc/trees/thread_proxy.cc View 9 chunks +4 lines, -40 lines 0 comments Download
M components/view_manager/surfaces/surfaces_scheduler.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/view_manager/surfaces/surfaces_scheduler.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (15 generated)
danakj
+jam for components/
5 years, 6 months ago (2015-06-19 01:13:59 UTC) #2
danakj
Depends on https://codereview.chromium.org/1194623003/ to apply
5 years, 6 months ago (2015-06-19 01:16:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/1
5 years, 6 months ago (2015-06-19 04:11:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/83251) android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 6 months ago (2015-06-19 04:29:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/20001
5 years, 6 months ago (2015-06-19 05:13:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/40001
5 years, 6 months ago (2015-06-19 05:16:47 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/101148)
5 years, 6 months ago (2015-06-19 06:31:51 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/40001
5 years, 6 months ago (2015-06-19 06:34:38 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/101162)
5 years, 6 months ago (2015-06-19 07:46:33 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/60001
5 years, 6 months ago (2015-06-19 09:06:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/80001
5 years, 6 months ago (2015-06-19 09:07:33 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/83310)
5 years, 6 months ago (2015-06-19 09:24:09 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/100001
5 years, 6 months ago (2015-06-19 16:40:48 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/37011) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 6 months ago (2015-06-19 16:46:14 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194743002/100001
5 years, 6 months ago (2015-06-19 17:19:07 UTC) #30
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 6 months ago (2015-06-19 17:56:24 UTC) #31
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 17:57:22 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4dac85e8857e3adec857749c68a893e8f1448e7d
Cr-Commit-Position: refs/heads/master@{#335287}

Powered by Google App Engine
This is Rietveld 408576698