Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/chromeos/first_run/drive_first_run_controller.cc

Issue 1194383003: Add a flag showing whether the current request was ignored by a handler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix trybot failures (DidFailProvisionalLoad calls in unit tests) Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/first_run/drive_first_run_controller.cc
diff --git a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
index 89ddeccd5aa6f8046b460fb1db4fcc158fce6dbf..c2d0de6c06f94f4636a1ae9752fe1f224ada119e 100644
--- a/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
+++ b/chrome/browser/chromeos/first_run/drive_first_run_controller.cc
@@ -151,12 +151,14 @@ class DriveWebContentsManager : public content::WebContentsObserver,
void DidFailProvisionalLoad(content::RenderFrameHost* render_frame_host,
const GURL& validated_url,
int error_code,
- const base::string16& error_description) override;
+ const base::string16& error_description,
+ bool was_ignored_by_handler) override;
void DidFailLoad(content::RenderFrameHost* render_frame_host,
const GURL& validated_url,
int error_code,
- const base::string16& error_description) override;
+ const base::string16& error_description,
+ bool was_ignored_by_handler) override;
// content::WebContentsDelegate overrides:
bool ShouldCreateWebContents(
@@ -253,7 +255,8 @@ void DriveWebContentsManager::DidFailProvisionalLoad(
content::RenderFrameHost* render_frame_host,
const GURL& validated_url,
int error_code,
- const base::string16& error_description) {
+ const base::string16& error_description,
+ bool was_ignored_by_handler) {
if (!render_frame_host->GetParent()) {
LOG(WARNING) << "Failed to load WebContents to enable offline mode.";
OnOfflineInit(false,
@@ -265,7 +268,8 @@ void DriveWebContentsManager::DidFailLoad(
content::RenderFrameHost* render_frame_host,
const GURL& validated_url,
int error_code,
- const base::string16& error_description) {
+ const base::string16& error_description,
+ bool was_ignored_by_handler) {
if (!render_frame_host->GetParent()) {
LOG(WARNING) << "Failed to load WebContents to enable offline mode.";
OnOfflineInit(false,

Powered by Google App Engine
This is Rietveld 408576698