Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1194123003: [PresentationAPI] on-session-message handler for ArrayBuffer and Blob messages. (Closed)

Created:
5 years, 6 months ago by USE s.singapati at gmail.com
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PresentationAPI] on-session-message handler for ArrayBuffer and Blob messages. Depends on the Blink CL: https://codereview.chromium.org/1206513004/ BUG=459008 Committed: https://crrev.com/09f3699d4c094c327b2a70ae6a9229092207c982 Cr-Commit-Position: refs/heads/master@{#338263}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : wrap PresentationSessionClient in scoped_ptr. #

Total comments: 1

Patch Set 4 : generic interface to receive a binary messages. #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M content/renderer/presentation/presentation_dispatcher.cc View 1 2 3 4 1 chunk +26 lines, -8 lines 0 comments Download

Messages

Total messages: 23 (8 generated)
USE s.singapati at gmail.com
5 years, 6 months ago (2015-06-23 12:49:14 UTC) #2
Habib Virji
https://codereview.chromium.org/1194123003/diff/1/content/renderer/presentation/presentation_dispatcher.cc File content/renderer/presentation/presentation_dispatcher.cc (right): https://codereview.chromium.org/1194123003/diff/1/content/renderer/presentation/presentation_dispatcher.cc#newcode376 content/renderer/presentation/presentation_dispatcher.cc:376: new PresentationSessionClient(messages[i]->presentation_url, This can be handled prior to the ...
5 years, 6 months ago (2015-06-23 13:04:23 UTC) #3
USE s.singapati at gmail.com
Hi Habib, Thanks for review. Is it ok to proceed? https://codereview.chromium.org/1194123003/diff/1/content/renderer/presentation/presentation_dispatcher.cc File content/renderer/presentation/presentation_dispatcher.cc (right): https://codereview.chromium.org/1194123003/diff/1/content/renderer/presentation/presentation_dispatcher.cc#newcode376 ...
5 years, 6 months ago (2015-06-23 15:06:35 UTC) #4
Habib Virji
Yes please proceed.
5 years, 6 months ago (2015-06-23 15:11:01 UTC) #5
USE s.singapati at gmail.com
PTAL.
5 years, 6 months ago (2015-06-23 15:20:35 UTC) #7
imcheng (use chromium acct)
https://codereview.chromium.org/1194123003/diff/20001/content/renderer/presentation/presentation_dispatcher.cc File content/renderer/presentation/presentation_dispatcher.cc (right): https://codereview.chromium.org/1194123003/diff/20001/content/renderer/presentation/presentation_dispatcher.cc#newcode372 content/renderer/presentation/presentation_dispatcher.cc:372: PresentationSessionClient* session_client = new PresentationSessionClient( Since you moved the ...
5 years, 6 months ago (2015-06-23 22:08:31 UTC) #9
USE s.singapati at gmail.com
PTaL. https://codereview.chromium.org/1194123003/diff/20001/content/renderer/presentation/presentation_dispatcher.cc File content/renderer/presentation/presentation_dispatcher.cc (right): https://codereview.chromium.org/1194123003/diff/20001/content/renderer/presentation/presentation_dispatcher.cc#newcode372 content/renderer/presentation/presentation_dispatcher.cc:372: PresentationSessionClient* session_client = new PresentationSessionClient( On 2015/06/23 22:08:31, ...
5 years, 6 months ago (2015-06-25 15:34:30 UTC) #10
mark a. foltz
LGTM https://codereview.chromium.org/1194123003/diff/40001/content/renderer/presentation/presentation_dispatcher.cc File content/renderer/presentation/presentation_dispatcher.cc (right): https://codereview.chromium.org/1194123003/diff/40001/content/renderer/presentation/presentation_dispatcher.cc#newcode373 content/renderer/presentation/presentation_dispatcher.cc:373: new PresentationSessionClient(messages[i]->presentation_url, It appears that this ctor will ...
5 years, 5 months ago (2015-06-29 22:21:28 UTC) #11
USE s.singapati at gmail.com
PTAL.
5 years, 5 months ago (2015-06-30 14:32:47 UTC) #12
whywhat
On 2015/06/30 at 14:32:47, s.singapati wrote: > PTAL. lgtm If you've got lgtm already with ...
5 years, 5 months ago (2015-07-07 13:01:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194123003/80001
5 years, 5 months ago (2015-07-10 05:51:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_android/builds/29070) linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 06:03:24 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194123003/80001
5 years, 5 months ago (2015-07-10 08:06:05 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-10 09:06:56 UTC) #22
commit-bot: I haz the power
5 years, 5 months ago (2015-07-10 09:07:36 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/09f3699d4c094c327b2a70ae6a9229092207c982
Cr-Commit-Position: refs/heads/master@{#338263}

Powered by Google App Engine
This is Rietveld 408576698