[PresentationAPI] on-session-message handler for ArrayBuffer and Blob messages.

content/renderer/presentation/presentation_dispatcher.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/presentation/presentation_dispatcher.h"
 
 #include "base/logging.h"
 #include "content/common/presentation/presentation_service.mojom.h"
 #include "content/public/common/presentation_constants.h"
 #include "content/public/common/service_registry.h"
@@ skipping 351 matching lines @@
       GetWebPresentationSessionStateFromMojo(session_state));
 }
 
 void PresentationDispatcher::OnSessionMessagesReceived(
     mojo::Array<presentation::SessionMessagePtr> messages) {
   // When messages is null, there is an error at presentation service side.
   if (!controller_ || messages.is_null())
     return;
 
   for (size_t i = 0; i < messages.size(); ++i) {
-    if (messages[i]->type ==
-        presentation::PresentationMessageType::PRESENTATION_MESSAGE_TYPE_TEXT) {
-      controller_->didReceiveSessionTextMessage(
-          new PresentationSessionClient(messages[i]->presentation_url,
-                                        messages[i]->presentation_id),
-          blink::WebString::fromUTF8(messages[i]->message));
-    } else {
-      // TODO(haibinlu): handle binary message
+    PresentationSessionClient* session_client = new PresentationSessionClient(

[imcheng (use chromium acct), 2015/06/23 22:08:31]

Since you moved the allocation of PresentationSessionClient out-of-line, I would
suggest wrapped it in a scoped_ptr, and then invoking session_client.Pass() in
the non-default cases. Then you won't have to manually call delete in the
default case. I believe this would be less error prone than manually managing
new'ed memory.

[USE s.singapati at gmail.com, 2015/06/25 15:34:29]

Done. Used session_client.release() as it takes WebPresentationSessionClient*.

+        messages[i]->presentation_url, messages[i]->presentation_id);
+    switch (messages[i]->type) {
+      case presentation::PresentationMessageType::
+          PRESENTATION_MESSAGE_TYPE_TEXT: {
+        controller_->didReceiveSessionTextMessage(
+            session_client, blink::WebString::fromUTF8(messages[i]->message));
+        break;
+      }
+      case presentation::PresentationMessageType::
+          PRESENTATION_MESSAGE_TYPE_ARRAY_BUFFER: {
+        controller_->didReceiveSessionArrayBufferMessage(
+            session_client, &(messages[i]->data.front()),
+            messages[i]->data.size());
+        break;
+      }
+      case presentation::PresentationMessageType::
+          PRESENTATION_MESSAGE_TYPE_BLOB: {
+        controller_->didReceiveSessionBlobMessage(session_client,
+                                                  &(messages[i]->data.front()),
+                                                  messages[i]->data.size());
+        break;
+      }
+      default: {
+        delete session_client;
+        NOTREACHED();
+        break;
+      }
     }
   }
 
   presentation_service_->ListenForSessionMessages(
       base::Bind(&PresentationDispatcher::OnSessionMessagesReceived,
                  base::Unretained(this)));
 }
 
 void PresentationDispatcher::ConnectToPresentationServiceIfNeeded() {
   if (presentation_service_.get())
@@ skipping 14 matching lines @@
   presentation_service_->ListenForSessionStateChange(base::Bind(
       &PresentationDispatcher::OnSessionStateChange,
       base::Unretained(this)));
   presentation_service_->ListenForSessionMessages(
       base::Bind(&PresentationDispatcher::OnSessionMessagesReceived,
       base::Unretained(this)));
   */
 }
 
 }  // namespace content