Prevent VK flashing after press a button in login header bar

Prevent VK flashing after press a button in login header bar

BUG=502261
Committed: https://crrev.com/c1313942d2c2f542091b1ef197012e69746cfdd3
Cr-Commit-Position: refs/heads/master@{#335729}

[bshe, 2015-06-19 14:48:07]

bshe@chromium.org changed reviewers:
+ dzhioev@chromium.org

[bshe, 2015-06-19 14:48:07]

Hi Pavel.

Do you mind to take a look at this CL? While working on a different VK issue, I
notice a VK flashing problem at login screen.

I think what happened is that user pod row listen to click event on document
level, and when user click a button on header bar, user pod row will try to
focus on a user pod which triggers VK to show. Then user pod lost focus which
then hides VK immediately. A VK flashing is observed during the process.

This CL simply prevent focus user pod if the click is from header bar. I am not
familiar with login code and this is just a first attempt. Let me know if there
is a better way to fix it. Thanks!

[dzhioev (left Google), 2015-06-19 21:03:45]

On 2015/06/19 14:48:07, bshe wrote:
> Hi Pavel.
> 
> Do you mind to take a look at this CL? While working on a different VK issue,
I
> notice a VK flashing problem at login screen.
> 
> I think what happened is that user pod row listen to click event on document
> level, and when user click a button on header bar, user pod row will try to
> focus on a user pod which triggers VK to show. Then user pod lost focus which
> then hides VK immediately. A VK flashing is observed during the process.
> 
> This CL simply prevent focus user pod if the click is from header bar. I am
not
> familiar with login code and this is just a first attempt. Let me know if
there
> is a better way to fix it. Thanks!

LGTM

[bshe, 2015-06-22 13:13:52]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-06-22 13:14:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1193923003/1

[commit-bot: I haz the power, 2015-06-22 14:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-22 14:02:35]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[bshe, 2015-06-23 15:27:43]

The CQ bit was checked by bshe@chromium.org

[bshe, 2015-06-23 15:27:43]

The patchset sent to the CQ was uploaded after l-g-t-m from dzhioev@chromium.org
Link to the patchset: https://codereview.chromium.org/1193923003/#ps40001
(title: "uprev")

[commit-bot: I haz the power, 2015-06-23 15:28:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1193923003/40001

[commit-bot: I haz the power, 2015-06-23 15:52:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-23 15:52:14]

Exceeded global retry quota

[bshe, 2015-06-23 20:09:32]

The CQ bit was checked by bshe@chromium.org

[commit-bot: I haz the power, 2015-06-23 20:11:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1193923003/40001

[commit-bot: I haz the power, 2015-06-23 20:16:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-23 20:17:47]

Patchset 3 (id:??) landed as
https://crrev.com/c1313942d2c2f542091b1ef197012e69746cfdd3
Cr-Commit-Position: refs/heads/master@{#335729}