Issue 11938029: Remove <(library) usage from ots.gyp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11938029: Remove <(library) usage from ots.gyp. (Closed)

Created:
7 years, 11 months ago by tfarina

Modified:
7 years, 11 months ago

Reviewers:
Yusuke Sato

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/external/ots.git@master

Visibility:
Public.

More Reviews

Description

Remove <(library) usage from ots.gyp. BUG=111541 R=yusukes@chromium.org Signed-off-by: Thiago Farina <tfarina@chromium.org>;

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	ots.gyp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

tfarina

Hi Yusuke, when you approve this, could land it to me? Thanks,

7 years, 11 months ago (2013-01-18 21:06:21 UTC) #2

Yusuke Sato

7 years, 11 months ago (2013-01-19 04:42:21 UTC) #3

On 2013/01/18 21:06:21, tfarina wrote:
> Hi Yusuke, when you approve this, could land it to me?
> 
> Thanks,

LGTM.

Landed in https://code.google.com/p/ots/source/detail?r=97 . Please roll Chrome
DEPS yourself.

Expand Messages | Collapse Messages