Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 11938006: Turn off the network proxy for mac and win in DRT (Closed)

Created:
7 years, 11 months ago by Dirk Pranke
Modified:
7 years, 10 months ago
Reviewers:
tony, eroman
CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, cmp, kerz_chromium, ojan, jochen (gone - plz use gerrit)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Turn off the network proxy for mac and win in DRT The original test_shell code was written to use the system proxy autoconfig. On windows, at least, this was known to be flaky at best. However, this still made sense because we needed to be able to use test_shell to view arbitrary pages on the web, and we didn't have an alternative. However, we don't really use test_shell anymore, and the same code is used by DumpRenderTree, which only views pages on the local machine and has no need for the proxy at all. This patch changes the net config to never use a proxy on any platform. R=tony@chromium.org, eroman@chromium.org BUG=170429 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181358

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -15 lines) Patch
M webkit/tools/test_shell/test_shell_request_context.cc View 1 chunk +2 lines, -15 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Dirk Pranke
7 years, 11 months ago (2013-01-18 00:28:02 UTC) #1
Dirk Pranke
note that it's possible this'll cause a few tests to start failing due to the ...
7 years, 11 months ago (2013-01-18 00:29:02 UTC) #2
tony
LGTM, please make sure that test_shell_tests all pass for you on Win or Mac (I ...
7 years, 11 months ago (2013-01-18 00:37:06 UTC) #3
eroman
lgtm
7 years, 11 months ago (2013-01-18 00:38:43 UTC) #4
tony
When running tests under content_shell, can we also turn off the network proxy?
7 years, 11 months ago (2013-01-18 00:39:52 UTC) #5
Dirk Pranke
On 2013/01/18 00:39:52, tony wrote: > When running tests under content_shell, can we also turn ...
7 years, 11 months ago (2013-01-18 01:22:07 UTC) #6
Dirk Pranke
test_shell_tests ran fine on mac and win.
7 years, 11 months ago (2013-01-18 02:16:01 UTC) #7
Dirk Pranke
7 years, 10 months ago (2013-02-07 03:30:32 UTC) #8
On 2013/01/18 02:16:01, Dirk Pranke wrote:
> test_shell_tests ran fine on mac and win.

wtf ... apparently I never actually landed this. Not sure how that happened.
Re-running try jobs and trying again.

Powered by Google App Engine
This is Rietveld 408576698