Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: webkit/tools/test_shell/test_shell_request_context.cc

Issue 11938006: Turn off the network proxy for mac and win in DRT (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/test_shell_request_context.cc
diff --git a/webkit/tools/test_shell/test_shell_request_context.cc b/webkit/tools/test_shell/test_shell_request_context.cc
index 5bdf4c954e30ae1433277232c9cc006522ea8d58..d6fb0f5ded10e09b2d1cd0a7f7f432870bde2a34 100644
--- a/webkit/tools/test_shell/test_shell_request_context.cc
+++ b/webkit/tools/test_shell/test_shell_request_context.cc
@@ -80,23 +80,10 @@ void TestShellRequestContext::Init(
storage_.set_http_user_agent_settings(new TestShellHttpUserAgentSettings);
-#if defined(OS_POSIX) && !defined(OS_MACOSX)
- // Use no proxy to avoid ProxyConfigServiceLinux.
- // Enabling use of the ProxyConfigServiceLinux requires:
- // -Calling from a thread with a TYPE_UI MessageLoop,
- // -If at all possible, passing in a pointer to the IO thread's MessageLoop,
- // -Keep in mind that proxy auto configuration is also
- // non-functional on linux in this context because of v8 threading
- // issues.
- // TODO(port): rename "linux" to some nonspecific unix.
+ // Use no proxy; it's not needed for testing and just breaks things.
scoped_ptr<net::ProxyConfigService> proxy_config_service(
new net::ProxyConfigServiceFixed(net::ProxyConfig()));
-#else
- // Use the system proxy settings.
- scoped_ptr<net::ProxyConfigService> proxy_config_service(
- net::ProxyService::CreateSystemProxyConfigService(
- base::ThreadTaskRunnerHandle::Get(), NULL));
-#endif
+
storage_.set_host_resolver(net::HostResolver::CreateDefaultResolver(NULL));
storage_.set_cert_verifier(net::CertVerifier::CreateDefault());
storage_.set_proxy_service(net::ProxyService::CreateUsingSystemProxyResolver(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698