Source/bindings/scripts/v8_utilities.py - Issue 1193793003: bindings: Makes almost all attributes accessor-type properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_utilities.py

Issue 1193793003: bindings: Makes almost all attributes accessor-type properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Synced. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_utilities.py

diff --git a/Source/bindings/scripts/v8_utilities.py b/Source/bindings/scripts/v8_utilities.py

index 1cd44abbe378c6d69e80cb8f24d0d6a28e0f9958..e1e584be75bec46fea220ae4828f19f69518b38c 100644

--- a/Source/bindings/scripts/v8_utilities.py

+++ b/Source/bindings/scripts/v8_utilities.py

@@ -422,6 +422,8 @@ def on_instance(interface, member):

- members on which [DoNotExposeJSAccessors] is specified

"""

# TODO(yukishiino): Implement this function following the spec.

+ if member.is_static:

+ return False

return not on_prototype(interface, member)

@@ -486,6 +488,8 @@ def on_interface(interface, member):

- static members

"""

# TODO(yukishiino): Implement this function following the spec.

+ if member.is_static:

+ return True

return False

« no previous file with comments | « Source/bindings/scripts/v8_interface.py ('k') | Source/bindings/templates/attributes.cpp » ('j') | no next file with comments »