Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 1193793003: bindings: Makes almost all attributes accessor-type properties. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Synced. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/v8_interface.py
diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py
index 406fee3ea90f3e71b91bbf804cda892c8fb5bab7..9cc669476b6722ebe642e8fc6d2c5e15b6050133 100644
--- a/Source/bindings/scripts/v8_interface.py
+++ b/Source/bindings/scripts/v8_interface.py
@@ -288,17 +288,17 @@ def interface_context(interface):
context.update({
'attributes': attributes,
'has_accessor_configuration': any(
- attribute['is_expose_js_accessors'] and
- not (attribute['is_static'] or
+ not (attribute['exposed_test'] or
attribute['runtime_enabled_function']) and
+ not attribute['is_data_type_property'] and
attribute['should_be_exposed_to_script']
for attribute in attributes),
'has_attribute_configuration': any(
- not (attribute['is_expose_js_accessors'] or
- attribute['is_static'] or
- attribute['runtime_enabled_function'])
- and attribute['should_be_exposed_to_script']
- for attribute in attributes),
+ not (attribute['exposed_test'] or
+ attribute['runtime_enabled_function']) and
+ attribute['is_data_type_property'] and
+ attribute['should_be_exposed_to_script']
+ for attribute in attributes),
'has_constructor_attributes': any(attribute['constructor_type'] for attribute in attributes),
'has_replaceable_attributes': any(attribute['is_replaceable'] for attribute in attributes),
})
« no previous file with comments | « Source/bindings/scripts/v8_attributes.py ('k') | Source/bindings/scripts/v8_utilities.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698