Source/core/css/CSSPrimitiveValue.h - Issue 1193753002: Serialize zIndex as an integer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.h

Issue 1193753002: Serialize zIndex as an integer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix regression and add test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSPrimitiveValue.h

diff --git a/Source/core/css/CSSPrimitiveValue.h b/Source/core/css/CSSPrimitiveValue.h

index 7ed725f032aa6b89b92a36b767b22efb52ddd789..3f7b65ed10fa47ffdcee0ea063f26b3bc7687402 100644

--- a/Source/core/css/CSSPrimitiveValue.h

+++ b/Source/core/css/CSSPrimitiveValue.h

@@ -106,6 +106,7 @@ public:

CSS_DPI = 31,

CSS_DPCM = 32,

CSS_FR = 33,

+ CSS_INTEGER = 34,

CSS_PAIR = 100,

CSS_TURN = 107,

CSS_REMS = 108,

@@ -184,7 +185,7 @@ public:

return (type >= CSS_EMS && type <= CSS_PC) || type == CSS_REMS || type == CSS_CHS || isViewportPercentageLength(type);

}

bool isLength() const { return isLength(primitiveType()); }

- bool isNumber() const { return primitiveType() == CSS_NUMBER; }

+ bool isNumber() const { return primitiveType() == CSS_NUMBER || primitiveType() == CSS_INTEGER; }

bool isPercentage() const { return primitiveType() == CSS_PERCENTAGE; }

bool isPx() const { return primitiveType() == CSS_PX; }

bool isRect() const { return m_primitiveUnitType == CSS_RECT; }