Enable compilation of angle_end2end_tests on Linux

Enable compilation of angle_end2end_tests on Linux

So that we can run it on the GPU FYI bots on Linux

BUG=501604
Committed: https://crrev.com/8e1e026913c6717bfd7f399dbcbe249692e2920a
Cr-Commit-Position: refs/heads/master@{#335149}

[Corentin Wallez, 2015-06-18 21:18:42]

cwallez@chromium.org changed reviewers:
+ geofflang@chromium.org, jmadill@google.com, kbr@chromium.org

[Corentin Wallez, 2015-06-18 21:18:43]

Can one of you launch the try jobs too? Thanks! PTAL

[Jamie Madill, 2015-06-18 21:23:28]

jmadill@chromium.org changed reviewers:
+ jmadill@chromium.org

[Jamie Madill, 2015-06-18 21:23:29]

LGTM but I'm not an owner. You'll need to add someone in gpu/OWNERS (piman or
sievers)

[Ken Russell (switch to Gerrit), 2015-06-18 21:23:54]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-18 21:24:13]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1193743002/1

[Corentin Wallez, 2015-06-18 22:18:49]

cwallez@chromium.org changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[Corentin Wallez, 2015-06-18 22:18:50]

Needing OWNERS' approval, PTAL

Thanks!

[commit-bot: I haz the power, 2015-06-18 22:29:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-18 22:29:10]

Dry run: This issue passed the CQ dry run.

[no sievers, 2015-06-18 22:31:13]

On 2015/06/18 22:29:10, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

lgtm

[Corentin Wallez, 2015-06-18 22:35:39]

On 2015/06/18 22:31:13, sievers wrote:
> On 2015/06/18 22:29:10, commit-bot: I haz the power wrote:
> > Dry run: This issue passed the CQ dry run.
> 
> lgtm

Thanks!

[Corentin Wallez, 2015-06-18 22:35:54]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2015-06-18 22:38:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1193743002/1

[commit-bot: I haz the power, 2015-06-18 22:43:57]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-06-18 22:44:48]

Patchset 1 (id:??) landed as
https://crrev.com/8e1e026913c6717bfd7f399dbcbe249692e2920a
Cr-Commit-Position: refs/heads/master@{#335149}

[Nico, 2015-06-19 01:22:51]

Looks like they don't always build with asan (maybe because it uses libc++):

http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/14...

FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o.d
-DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC -DCHROMIUM_BUILD
-DCR_CLANG_REVISION=240105 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
-DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
-DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
-DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
-DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV
-DDONT_EMBED_BUILD_METADATA -DADDRESS_SANITIZER -DMEMORY_TOOL_REPLACES_ALLOCATOR
-DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
-DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
-DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
-DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
-DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGTEST_HAS_POSIX_RE=0
-DGTEST_LANG_CXX11=0 -DGL_GLEXT_PROTOTYPES=
'-DANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES={ "d3dcompiler_47.dll",
"d3dcompiler_46.dll", "d3dcompiler_43.dll" }'
'-DGL_APICALL=__attribute__((visibility("default")))'
'-DEGLAPI=__attribute__((visibility("default")))' -DANGLE_ENABLE_OPENGL
-DANGLE_USE_X11 -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER
-DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-Igen -I../../third_party/angle/include -I../../third_party/angle/src/tests
-Igen/angle -I../../testing/gmock/include -I../../testing/gtest/include -I../..
-I../../third_party/angle/src -I../../third_party/angle/util
'-I../../buildtools/third_party/libc++/trunk/include'
'-I../../buildtools/third_party/libc++abi/trunk/include' -fstack-protector
--param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall
-Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe
-fPIC -Wno-reserved-user-defined-literal -fcolor-diagnostics
-B/b/build/slave/ClangToTLinuxASan/build/src/third_party/binutils/Linux_x64/Release/bin
-Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
-Wno-deprecated-register -Wno-inconsistent-missing-override -pthread
-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64
-march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address
-fsanitize=leak -O2 -fno-ident -fdata-sections -ffunction-sections
-funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
-fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++  -c
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp -o
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:79:20: error:
use of undeclared identifier 'floorf'
    maxPointSize = floorf(maxPointSize);
                   ^
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:84:37: error:
use of undeclared identifier 'floorf'
    GLint step = static_cast<GLint>(floorf(maxPointSize / 4));
                                    ^
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:132:47: error:
use of undeclared identifier 'floorf'
                    int xf = static_cast<int>(floorf(s2p(pointX + u *
pointWidth)));
                                              ^
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:133:47: error:
use of undeclared identifier 'floorf'
                    int yf = static_cast<int>(floorf(s2p(pointY + v *
pointWidth)));
                                              ^
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:63: error:
use of undeclared identifier 'floorf'
                    GLubyte color[4] = { static_cast<GLubyte>(floorf(s * 255)),
static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
                                                              ^
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:102: error:
use of undeclared identifier 'floorf'
                    GLubyte color[4] = { static_cast<GLubyte>(floorf(s * 255)),
static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
                                                                                
                    ^
6 errors generated.
ninja: build stopped: subcommand failed.

[Ken Russell (switch to Gerrit), 2015-06-19 01:33:38]

On 2015/06/19 01:22:51, Nico wrote:
> Looks like they don't always build with asan (maybe because it uses libc++):
> 
>
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/14...
> 
> FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o.d
> -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC
-DCHROMIUM_BUILD
> -DCR_CLANG_REVISION=240105 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
> -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
> -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
> -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
> -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
> -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DUSE_UDEV
> -DDONT_EMBED_BUILD_METADATA -DADDRESS_SANITIZER
-DMEMORY_TOOL_REPLACES_ALLOCATOR
> -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1
> -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
> -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
> -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
> -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
-DENABLE_SETTINGS_APP=1
> -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
> -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
> -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGTEST_HAS_POSIX_RE=0
> -DGTEST_LANG_CXX11=0 -DGL_GLEXT_PROTOTYPES=
> '-DANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES={ "d3dcompiler_47.dll",
> "d3dcompiler_46.dll", "d3dcompiler_43.dll" }'
> '-DGL_APICALL=__attribute__((visibility("default")))'
> '-DEGLAPI=__attribute__((visibility("default")))' -DANGLE_ENABLE_OPENGL
> -DANGLE_USE_X11 -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
> -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER
> -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND
-DDYNAMIC_ANNOTATIONS_ENABLED=0
> -Igen -I../../third_party/angle/include -I../../third_party/angle/src/tests
> -Igen/angle -I../../testing/gmock/include -I../../testing/gtest/include
-I../..
> -I../../third_party/angle/src -I../../third_party/angle/util
> '-I../../buildtools/third_party/libc++/trunk/include'
> '-I../../buildtools/third_party/libc++abi/trunk/include' -fstack-protector
> --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall
> -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden
-pipe
> -fPIC -Wno-reserved-user-defined-literal -fcolor-diagnostics
>
-B/b/build/slave/ClangToTLinuxASan/build/src/third_party/binutils/Linux_x64/Release/bin
> -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
> -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> -Wno-deprecated-register -Wno-inconsistent-missing-override -pthread
> -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64
> -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address
> -fsanitize=leak -O2 -fno-ident -fdata-sections -ffunction-sections
> -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
> -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++  -c
> ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp -o
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o
> ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:79:20: error:
> use of undeclared identifier 'floorf'
>     maxPointSize = floorf(maxPointSize);
>                    ^
> ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:84:37: error:
> use of undeclared identifier 'floorf'
>     GLint step = static_cast<GLint>(floorf(maxPointSize / 4));
>                                     ^
> ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:132:47: error:
> use of undeclared identifier 'floorf'
>                     int xf = static_cast<int>(floorf(s2p(pointX + u *
> pointWidth)));
>                                               ^
> ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:133:47: error:
> use of undeclared identifier 'floorf'
>                     int yf = static_cast<int>(floorf(s2p(pointY + v *
> pointWidth)));
>                                               ^
> ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:63: error:
> use of undeclared identifier 'floorf'
>                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
255)),
> static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
>                                                               ^
> ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:102:
error:
> use of undeclared identifier 'floorf'
>                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
255)),
> static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
>                                                                               
 
>                     ^
> 6 errors generated.
> ninja: build stopped: subcommand failed.

Sorry about the breakage.

floorf should be provided by math.h, yes? Do you have a local build, and could
we try fixing up the #includes in ANGLETest.h in it?

[Ken Russell (switch to Gerrit), 2015-06-19 01:45:58]

On 2015/06/19 01:33:38, Ken Russell wrote:
> On 2015/06/19 01:22:51, Nico wrote:
> > Looks like they don't always build with asan (maybe because it uses libc++):
> > 
> >
>
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/14...
> > 
> > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o.d
> > -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC
> -DCHROMIUM_BUILD
> > -DCR_CLANG_REVISION=240105 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
> > -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
> > -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
> > -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
> > -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
> > -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> -DUSE_UDEV
> > -DDONT_EMBED_BUILD_METADATA -DADDRESS_SANITIZER
> -DMEMORY_TOOL_REPLACES_ALLOCATOR
> > -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1
-DENABLE_EXTENSIONS=1
> > -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
> > -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
> > -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> > -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
> > -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
> -DENABLE_SETTINGS_APP=1
> > -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
> > -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
> > -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGTEST_HAS_POSIX_RE=0
> > -DGTEST_LANG_CXX11=0 -DGL_GLEXT_PROTOTYPES=
> > '-DANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES={ "d3dcompiler_47.dll",
> > "d3dcompiler_46.dll", "d3dcompiler_43.dll" }'
> > '-DGL_APICALL=__attribute__((visibility("default")))'
> > '-DEGLAPI=__attribute__((visibility("default")))' -DANGLE_ENABLE_OPENGL
> > -DANGLE_USE_X11 -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
> > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER
> > -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND
> -DDYNAMIC_ANNOTATIONS_ENABLED=0
> > -Igen -I../../third_party/angle/include -I../../third_party/angle/src/tests
> > -Igen/angle -I../../testing/gmock/include -I../../testing/gtest/include
> -I../..
> > -I../../third_party/angle/src -I../../third_party/angle/util
> > '-I../../buildtools/third_party/libc++/trunk/include'
> > '-I../../buildtools/third_party/libc++abi/trunk/include' -fstack-protector
> > --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall
> > -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden
> -pipe
> > -fPIC -Wno-reserved-user-defined-literal -fcolor-diagnostics
> >
>
-B/b/build/slave/ClangToTLinuxASan/build/src/third_party/binutils/Linux_x64/Release/bin
> > -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
> > -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> > -Wno-deprecated-register -Wno-inconsistent-missing-override -pthread
> > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64
> > -march=x86-64 -fno-omit-frame-pointer -gline-tables-only -fsanitize=address
> > -fsanitize=leak -O2 -fno-ident -fdata-sections -ffunction-sections
> > -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
> > -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++  -c
> > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp -o
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o
> > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:79:20:
error:
> > use of undeclared identifier 'floorf'
> >     maxPointSize = floorf(maxPointSize);
> >                    ^
> > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:84:37:
error:
> > use of undeclared identifier 'floorf'
> >     GLint step = static_cast<GLint>(floorf(maxPointSize / 4));
> >                                     ^
> > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:132:47:
error:
> > use of undeclared identifier 'floorf'
> >                     int xf = static_cast<int>(floorf(s2p(pointX + u *
> > pointWidth)));
> >                                               ^
> > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:133:47:
error:
> > use of undeclared identifier 'floorf'
> >                     int yf = static_cast<int>(floorf(s2p(pointY + v *
> > pointWidth)));
> >                                               ^
> > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:63:
error:
> > use of undeclared identifier 'floorf'
> >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
> 255)),
> > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> >                                                               ^
> > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:102:
> error:
> > use of undeclared identifier 'floorf'
> >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
> 255)),
> > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> >                                                                             
 
>  
> >                     ^
> > 6 errors generated.
> > ninja: build stopped: subcommand failed.
> 
> Sorry about the breakage.
> 
> floorf should be provided by math.h, yes? Do you have a local build, and could
> we try fixing up the #includes in ANGLETest.h in it?

Note: Corentin is trying to fix this up in
https://chromium-review.googlesource.com/280565 and we'll do another ANGLE roll
(via the CQ).

[Ken Russell (switch to Gerrit), 2015-06-19 02:11:25]

On 2015/06/19 01:45:58, Ken Russell wrote:
> On 2015/06/19 01:33:38, Ken Russell wrote:
> > On 2015/06/19 01:22:51, Nico wrote:
> > > Looks like they don't always build with asan (maybe because it uses
libc++):
> > > 
> > >
> >
>
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/14...
> > > 
> > > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> > >
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o.d
> > > -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC
> > -DCHROMIUM_BUILD
> > > -DCR_CLANG_REVISION=240105 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
> > > -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
> > > -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
> > > -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
> > > -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
> > > -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> > -DUSE_UDEV
> > > -DDONT_EMBED_BUILD_METADATA -DADDRESS_SANITIZER
> > -DMEMORY_TOOL_REPLACES_ALLOCATOR
> > > -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1
> -DENABLE_EXTENSIONS=1
> > > -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
> > > -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
> > > -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> > > -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
> > > -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
> > -DENABLE_SETTINGS_APP=1
> > > -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
> > > -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
> > > -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGTEST_HAS_POSIX_RE=0
> > > -DGTEST_LANG_CXX11=0 -DGL_GLEXT_PROTOTYPES=
> > > '-DANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES={ "d3dcompiler_47.dll",
> > > "d3dcompiler_46.dll", "d3dcompiler_43.dll" }'
> > > '-DGL_APICALL=__attribute__((visibility("default")))'
> > > '-DEGLAPI=__attribute__((visibility("default")))' -DANGLE_ENABLE_OPENGL
> > > -DANGLE_USE_X11 -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
> > > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER
> > > -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND
> > -DDYNAMIC_ANNOTATIONS_ENABLED=0
> > > -Igen -I../../third_party/angle/include
-I../../third_party/angle/src/tests
> > > -Igen/angle -I../../testing/gmock/include -I../../testing/gtest/include
> > -I../..
> > > -I../../third_party/angle/src -I../../third_party/angle/util
> > > '-I../../buildtools/third_party/libc++/trunk/include'
> > > '-I../../buildtools/third_party/libc++abi/trunk/include' -fstack-protector
> > > --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall
> > > -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden
> > -pipe
> > > -fPIC -Wno-reserved-user-defined-literal -fcolor-diagnostics
> > >
> >
>
-B/b/build/slave/ClangToTLinuxASan/build/src/third_party/binutils/Linux_x64/Release/bin
> > > -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
> > > -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> > > -Wno-deprecated-register -Wno-inconsistent-missing-override -pthread
> > > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -m64
> > > -march=x86-64 -fno-omit-frame-pointer -gline-tables-only
-fsanitize=address
> > > -fsanitize=leak -O2 -fno-ident -fdata-sections -ffunction-sections
> > > -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
> > > -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++  -c
> > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp -o
> > >
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o
> > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:79:20:
> error:
> > > use of undeclared identifier 'floorf'
> > >     maxPointSize = floorf(maxPointSize);
> > >                    ^
> > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:84:37:
> error:
> > > use of undeclared identifier 'floorf'
> > >     GLint step = static_cast<GLint>(floorf(maxPointSize / 4));
> > >                                     ^
> > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:132:47:
> error:
> > > use of undeclared identifier 'floorf'
> > >                     int xf = static_cast<int>(floorf(s2p(pointX + u *
> > > pointWidth)));
> > >                                               ^
> > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:133:47:
> error:
> > > use of undeclared identifier 'floorf'
> > >                     int yf = static_cast<int>(floorf(s2p(pointY + v *
> > > pointWidth)));
> > >                                               ^
> > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:63:
> error:
> > > use of undeclared identifier 'floorf'
> > >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
> > 255)),
> > > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> > >                                                               ^
> > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:102:
> > error:
> > > use of undeclared identifier 'floorf'
> > >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
> > 255)),
> > > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> > >                                                                           
 
>  
> >  
> > >                     ^
> > > 6 errors generated.
> > > ninja: build stopped: subcommand failed.
> > 
> > Sorry about the breakage.
> > 
> > floorf should be provided by math.h, yes? Do you have a local build, and
could
> > we try fixing up the #includes in ANGLETest.h in it?
> 
> Note: Corentin is trying to fix this up in
> https://chromium-review.googlesource.com/280565 and we'll do another ANGLE
roll
> (via the CQ).

Next ANGLE roll hopefully fixing this compile error:
https://codereview.chromium.org/1197543002/ .

[Adrian Kuegel, 2015-06-19 08:25:06]

On 2015/06/19 02:11:25, Ken Russell wrote:
> On 2015/06/19 01:45:58, Ken Russell wrote:
> > On 2015/06/19 01:33:38, Ken Russell wrote:
> > > On 2015/06/19 01:22:51, Nico wrote:
> > > > Looks like they don't always build with asan (maybe because it uses
> libc++):
> > > > 
> > > >
> > >
> >
>
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/14...
> > > > 
> > > > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD
-MF
> > > >
> > >
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o.d
> > > > -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC
> > > -DCHROMIUM_BUILD
> > > > -DCR_CLANG_REVISION=240105 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1
> > > > -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
> > > > -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
> > > > -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
> > > > -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
> > > > -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> > > -DUSE_UDEV
> > > > -DDONT_EMBED_BUILD_METADATA -DADDRESS_SANITIZER
> > > -DMEMORY_TOOL_REPLACES_ALLOCATOR
> > > > -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1
> > -DENABLE_EXTENSIONS=1
> > > > -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
> > > > -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
> > > > -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> > > > -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
> > > > -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
> > > -DENABLE_SETTINGS_APP=1
> > > > -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1
> > > > -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD
> > > > -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE -DGTEST_HAS_POSIX_RE=0
> > > > -DGTEST_LANG_CXX11=0 -DGL_GLEXT_PROTOTYPES=
> > > > '-DANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES={ "d3dcompiler_47.dll",
> > > > "d3dcompiler_46.dll", "d3dcompiler_43.dll" }'
> > > > '-DGL_APICALL=__attribute__((visibility("default")))'
> > > > '-DEGLAPI=__attribute__((visibility("default")))' -DANGLE_ENABLE_OPENGL
> > > > -DANGLE_USE_X11 -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
> > > > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER
> > > > -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND
> > > -DDYNAMIC_ANNOTATIONS_ENABLED=0
> > > > -Igen -I../../third_party/angle/include
> -I../../third_party/angle/src/tests
> > > > -Igen/angle -I../../testing/gmock/include -I../../testing/gtest/include
> > > -I../..
> > > > -I../../third_party/angle/src -I../../third_party/angle/util
> > > > '-I../../buildtools/third_party/libc++/trunk/include'
> > > > '-I../../buildtools/third_party/libc++abi/trunk/include'
-fstack-protector
> > > > --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall
> > > > -Wno-unused-parameter -Wno-missing-field-initializers
-fvisibility=hidden
> > > -pipe
> > > > -fPIC -Wno-reserved-user-defined-literal -fcolor-diagnostics
> > > >
> > >
> >
>
-B/b/build/slave/ClangToTLinuxASan/build/src/third_party/binutils/Linux_x64/Release/bin
> > > > -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration
> > > > -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> > > > -Wno-deprecated-register -Wno-inconsistent-missing-override -pthread
> > > > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
-m64
> > > > -march=x86-64 -fno-omit-frame-pointer -gline-tables-only
> -fsanitize=address
> > > > -fsanitize=leak -O2 -fno-ident -fdata-sections -ffunction-sections
> > > > -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
> > > > -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++  -c
> > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp -o
> > > >
> > >
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o
> > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:79:20:
> > error:
> > > > use of undeclared identifier 'floorf'
> > > >     maxPointSize = floorf(maxPointSize);
> > > >                    ^
> > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:84:37:
> > error:
> > > > use of undeclared identifier 'floorf'
> > > >     GLint step = static_cast<GLint>(floorf(maxPointSize / 4));
> > > >                                     ^
> > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:132:47:
> > error:
> > > > use of undeclared identifier 'floorf'
> > > >                     int xf = static_cast<int>(floorf(s2p(pointX + u *
> > > > pointWidth)));
> > > >                                               ^
> > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:133:47:
> > error:
> > > > use of undeclared identifier 'floorf'
> > > >                     int yf = static_cast<int>(floorf(s2p(pointY + v *
> > > > pointWidth)));
> > > >                                               ^
> > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:63:
> > error:
> > > > use of undeclared identifier 'floorf'
> > > >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
> > > 255)),
> > > > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> > > >                                                               ^
> > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:102:
> > > error:
> > > > use of undeclared identifier 'floorf'
> > > >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s *
> > > 255)),
> > > > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> > > >                                                                         
 
>  
> >  
> > >  
> > > >                     ^
> > > > 6 errors generated.
> > > > ninja: build stopped: subcommand failed.
> > > 
> > > Sorry about the breakage.
> > > 
> > > floorf should be provided by math.h, yes? Do you have a local build, and
> could
> > > we try fixing up the #includes in ANGLETest.h in it?
> > 
> > Note: Corentin is trying to fix this up in
> > https://chromium-review.googlesource.com/280565 and we'll do another ANGLE
> roll
> > (via the CQ).
> 
> Next ANGLE roll hopefully fixing this compile error:
> https://codereview.chromium.org/1197543002/ .

Is it possible that this CL also broke the ChromeOS Codesearch bot?
https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codese...
From the compile error it seems likely.

[Adrian Kuegel, 2015-06-19 09:53:35]

On 2015/06/19 08:25:06, Adrian Kuegel wrote:
> On 2015/06/19 02:11:25, Ken Russell wrote:
> > On 2015/06/19 01:45:58, Ken Russell wrote:
> > > On 2015/06/19 01:33:38, Ken Russell wrote:
> > > > On 2015/06/19 01:22:51, Nico wrote:
> > > > > Looks like they don't always build with asan (maybe because it uses
> > libc++):
> > > > > 
> > > > >
> > > >
> > >
> >
>
http://build.chromium.org/p/chromium.fyi/builders/ClangToTLinuxASan/builds/14...
> > > > > 
> > > > > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD
> -MF
> > > > >
> > > >
> > >
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o.d
> > > > > -DV8_DEPRECATION_WARNINGS -D_FILE_OFFSET_BITS=64 -DNO_TCMALLOC
> > > > -DCHROMIUM_BUILD
> > > > > -DCR_CLANG_REVISION=240105 -DUI_COMPOSITOR_IMAGE_TRANSPORT
-DUSE_AURA=1
> > > > > -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_DEFAULT_RENDER_THEME=1
> > > > > -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1
> > > > > -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1
> > > > > -DENABLE_WEBRTC=1 -DENABLE_MEDIA_ROUTER=1 -DENABLE_PEPPER_CDMS
> > > > > -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
> > > > -DUSE_UDEV
> > > > > -DDONT_EMBED_BUILD_METADATA -DADDRESS_SANITIZER
> > > > -DMEMORY_TOOL_REPLACES_ALLOCATOR
> > > > > -DMEMORY_SANITIZER_INITIAL_SIZE -DENABLE_TASK_MANAGER=1
> > > -DENABLE_EXTENSIONS=1
> > > > > -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
> > > > > -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1
> > > > > -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> > > > > -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1
> > > > > -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1
> > > > -DENABLE_SETTINGS_APP=1
> > > > > -DENABLE_SUPERVISED_USERS=1 -DENABLE_MDNS=1
-DENABLE_SERVICE_DISCOVERY=1
> > > > > -DV8_USE_EXTERNAL_STARTUP_DATA -DFULL_SAFE_BROWSING
-DSAFE_BROWSING_CSD
> > > > > -DSAFE_BROWSING_DB_LOCAL -DSAFE_BROWSING_SERVICE
-DGTEST_HAS_POSIX_RE=0
> > > > > -DGTEST_LANG_CXX11=0 -DGL_GLEXT_PROTOTYPES=
> > > > > '-DANGLE_PRELOADED_D3DCOMPILER_MODULE_NAMES={ "d3dcompiler_47.dll",
> > > > > "d3dcompiler_46.dll", "d3dcompiler_43.dll" }'
> > > > > '-DGL_APICALL=__attribute__((visibility("default")))'
> > > > > '-DEGLAPI=__attribute__((visibility("default")))'
-DANGLE_ENABLE_OPENGL
> > > > > -DANGLE_USE_X11 -DUSE_LIBPCI=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1
> > > > > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DLEAK_SANITIZER
> > > > > -DWTF_USE_LEAK_SANITIZER=1 -DNDEBUG -DNVALGRIND
> > > > -DDYNAMIC_ANNOTATIONS_ENABLED=0
> > > > > -Igen -I../../third_party/angle/include
> > -I../../third_party/angle/src/tests
> > > > > -Igen/angle -I../../testing/gmock/include
-I../../testing/gtest/include
> > > > -I../..
> > > > > -I../../third_party/angle/src -I../../third_party/angle/util
> > > > > '-I../../buildtools/third_party/libc++/trunk/include'
> > > > > '-I../../buildtools/third_party/libc++abi/trunk/include'
> -fstack-protector
> > > > > --param=ssp-buffer-size=4  -pthread -fno-strict-aliasing -Wall
> > > > > -Wno-unused-parameter -Wno-missing-field-initializers
> -fvisibility=hidden
> > > > -pipe
> > > > > -fPIC -Wno-reserved-user-defined-literal -fcolor-diagnostics
> > > > >
> > > >
> > >
> >
>
-B/b/build/slave/ClangToTLinuxASan/build/src/third_party/binutils/Linux_x64/Release/bin
> > > > > -Wheader-hygiene -Wno-char-subscripts
-Wno-unneeded-internal-declaration
> > > > > -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing
> > > > > -Wno-deprecated-register -Wno-inconsistent-missing-override -pthread
> > > > > -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include
> -m64
> > > > > -march=x86-64 -fno-omit-frame-pointer -gline-tables-only
> > -fsanitize=address
> > > > > -fsanitize=leak -O2 -fno-ident -fdata-sections -ffunction-sections
> > > > > -funwind-tables -fno-exceptions -fno-rtti -fno-threadsafe-statics
> > > > > -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -nostdinc++ 
-c
> > > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp -o
> > > > >
> > > >
> > >
> >
>
obj/third_party/angle/src/tests/gl_tests/angle_end2end_tests.PointSpritesTest.o
> > > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:79:20:
> > > error:
> > > > > use of undeclared identifier 'floorf'
> > > > >     maxPointSize = floorf(maxPointSize);
> > > > >                    ^
> > > > > ../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:84:37:
> > > error:
> > > > > use of undeclared identifier 'floorf'
> > > > >     GLint step = static_cast<GLint>(floorf(maxPointSize / 4));
> > > > >                                     ^
> > > > >
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:132:47:
> > > error:
> > > > > use of undeclared identifier 'floorf'
> > > > >                     int xf = static_cast<int>(floorf(s2p(pointX + u *
> > > > > pointWidth)));
> > > > >                                               ^
> > > > >
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:133:47:
> > > error:
> > > > > use of undeclared identifier 'floorf'
> > > > >                     int yf = static_cast<int>(floorf(s2p(pointY + v *
> > > > > pointWidth)));
> > > > >                                               ^
> > > > >
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:63:
> > > error:
> > > > > use of undeclared identifier 'floorf'
> > > > >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s
*
> > > > 255)),
> > > > > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> > > > >                                                               ^
> > > > >
../../third_party/angle/src/tests/gl_tests/PointSpritesTest.cpp:136:102:
> > > > error:
> > > > > use of undeclared identifier 'floorf'
> > > > >                     GLubyte color[4] = { static_cast<GLubyte>(floorf(s
*
> > > > 255)),
> > > > > static_cast<GLubyte>(floorf((1 - t) * 255)), 0, 255 };
> > > > >                                                                       
 
>  
> >  
> > >  
> > > >  
> > > > >                     ^
> > > > > 6 errors generated.
> > > > > ninja: build stopped: subcommand failed.
> > > > 
> > > > Sorry about the breakage.
> > > > 
> > > > floorf should be provided by math.h, yes? Do you have a local build, and
> > could
> > > > we try fixing up the #includes in ANGLETest.h in it?
> > > 
> > > Note: Corentin is trying to fix this up in
> > > https://chromium-review.googlesource.com/280565 and we'll do another ANGLE
> > roll
> > > (via the CQ).
> > 
> > Next ANGLE roll hopefully fixing this compile error:
> > https://codereview.chromium.org/1197543002/ .
> 
> Is it possible that this CL also broke the ChromeOS Codesearch bot?
>
https://build.chromium.org/p/chromium.infra.cron/builders/ChromiumOS%20Codese...
> From the compile error it seems likely.

Filed crbug.com/502198

[Ken Russell (switch to Gerrit), 2015-06-23 06:30:13]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1193103009/ by kbr@chromium.org.

The reason for reverting is: Seems to have caused intermittent tryjob failures
on one Chrome OS builder; see http://crbug.com/503173 .
.