Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1183)

Unified Diff: Source/core/paint/LayerFixedPositionRecorder.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add ListContainer::AllocateAndConstructWithArguments and a TODO in DisplayItemList::findMatchingIte… Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/paint/LayerClipRecorderTest.cpp ('k') | Source/core/paint/LayoutObjectDrawingRecorderTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/paint/LayerFixedPositionRecorder.cpp
diff --git a/Source/core/paint/LayerFixedPositionRecorder.cpp b/Source/core/paint/LayerFixedPositionRecorder.cpp
index f823fbc8b0990189d83ef8d750d950d6abbe7afa..0e310756d0c8a9437a0484732984c6594e8685b8 100644
--- a/Source/core/paint/LayerFixedPositionRecorder.cpp
+++ b/Source/core/paint/LayerFixedPositionRecorder.cpp
@@ -27,13 +27,13 @@ LayerFixedPositionRecorder::LayerFixedPositionRecorder(GraphicsContext& graphics
return;
if (m_isFixedPosition)
- m_graphicsContext.displayItemList()->add(BeginFixedPositionDisplayItem::create(m_layoutObject));
+ m_graphicsContext.displayItemList()->createAndAppend<BeginFixedPositionDisplayItem>(m_layoutObject);
// TODO(trchen): Adding a pair of display items on every transformed
// element can be expensive. Investigate whether we can optimize out some
// of them if applicable.
if (m_isFixedPositionContainer)
- m_graphicsContext.displayItemList()->add(BeginFixedPositionContainerDisplayItem::create(m_layoutObject));
+ m_graphicsContext.displayItemList()->createAndAppend<BeginFixedPositionContainerDisplayItem>(m_layoutObject);
}
LayerFixedPositionRecorder::~LayerFixedPositionRecorder()
@@ -48,14 +48,14 @@ LayerFixedPositionRecorder::~LayerFixedPositionRecorder()
if (m_graphicsContext.displayItemList()->lastDisplayItemIsNoopBegin())
m_graphicsContext.displayItemList()->removeLastDisplayItem();
else
- m_graphicsContext.displayItemList()->add(EndFixedPositionContainerDisplayItem::create(m_layoutObject));
+ m_graphicsContext.displayItemList()->createAndAppend<EndFixedPositionDisplayItem>(m_layoutObject);
}
if (m_isFixedPosition) {
if (m_graphicsContext.displayItemList()->lastDisplayItemIsNoopBegin())
m_graphicsContext.displayItemList()->removeLastDisplayItem();
else
- m_graphicsContext.displayItemList()->add(EndFixedPositionDisplayItem::create(m_layoutObject));
+ m_graphicsContext.displayItemList()->createAndAppend<EndFixedPositionDisplayItem>(m_layoutObject);
}
}
« no previous file with comments | « Source/core/paint/LayerClipRecorderTest.cpp ('k') | Source/core/paint/LayoutObjectDrawingRecorderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698