Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: Source/core/paint/LayerFixedPositionRecorder.cpp

Issue 1193433004: Blink-side contiguous allocation of display items. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add ListContainer::AllocateAndConstructWithArguments and a TODO in DisplayItemList::findMatchingIte… Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/paint/LayerFixedPositionRecorder.h" 6 #include "core/paint/LayerFixedPositionRecorder.h"
7 7
8 #include "core/layout/LayoutBoxModelObject.h" 8 #include "core/layout/LayoutBoxModelObject.h"
9 #include "platform/RuntimeEnabledFeatures.h" 9 #include "platform/RuntimeEnabledFeatures.h"
10 #include "platform/graphics/GraphicsContext.h" 10 #include "platform/graphics/GraphicsContext.h"
11 #include "platform/graphics/paint/DisplayItemList.h" 11 #include "platform/graphics/paint/DisplayItemList.h"
12 #include "platform/graphics/paint/FixedPositionContainerDisplayItem.h" 12 #include "platform/graphics/paint/FixedPositionContainerDisplayItem.h"
13 #include "platform/graphics/paint/FixedPositionDisplayItem.h" 13 #include "platform/graphics/paint/FixedPositionDisplayItem.h"
14 14
15 namespace blink { 15 namespace blink {
16 16
17 LayerFixedPositionRecorder::LayerFixedPositionRecorder(GraphicsContext& graphics Context, const LayoutBoxModelObject& layoutObject) 17 LayerFixedPositionRecorder::LayerFixedPositionRecorder(GraphicsContext& graphics Context, const LayoutBoxModelObject& layoutObject)
18 : m_graphicsContext(graphicsContext) 18 : m_graphicsContext(graphicsContext)
19 , m_layoutObject(layoutObject) 19 , m_layoutObject(layoutObject)
20 , m_isFixedPosition(layoutObject.style()->position() == FixedPosition) 20 , m_isFixedPosition(layoutObject.style()->position() == FixedPosition)
21 , m_isFixedPositionContainer(layoutObject.canContainFixedPositionObjects()) 21 , m_isFixedPositionContainer(layoutObject.canContainFixedPositionObjects())
22 { 22 {
23 if (!RuntimeEnabledFeatures::slimmingPaintCompositorLayerizationEnabled()) 23 if (!RuntimeEnabledFeatures::slimmingPaintCompositorLayerizationEnabled())
24 return; 24 return;
25 25
26 if (m_graphicsContext.displayItemList()->displayItemConstructionIsDisabled() ) 26 if (m_graphicsContext.displayItemList()->displayItemConstructionIsDisabled() )
27 return; 27 return;
28 28
29 if (m_isFixedPosition) 29 if (m_isFixedPosition)
30 m_graphicsContext.displayItemList()->add(BeginFixedPositionDisplayItem:: create(m_layoutObject)); 30 m_graphicsContext.displayItemList()->createAndAppend<BeginFixedPositionD isplayItem>(m_layoutObject);
31 31
32 // TODO(trchen): Adding a pair of display items on every transformed 32 // TODO(trchen): Adding a pair of display items on every transformed
33 // element can be expensive. Investigate whether we can optimize out some 33 // element can be expensive. Investigate whether we can optimize out some
34 // of them if applicable. 34 // of them if applicable.
35 if (m_isFixedPositionContainer) 35 if (m_isFixedPositionContainer)
36 m_graphicsContext.displayItemList()->add(BeginFixedPositionContainerDisp layItem::create(m_layoutObject)); 36 m_graphicsContext.displayItemList()->createAndAppend<BeginFixedPositionC ontainerDisplayItem>(m_layoutObject);
37 } 37 }
38 38
39 LayerFixedPositionRecorder::~LayerFixedPositionRecorder() 39 LayerFixedPositionRecorder::~LayerFixedPositionRecorder()
40 { 40 {
41 if (!RuntimeEnabledFeatures::slimmingPaintCompositorLayerizationEnabled()) 41 if (!RuntimeEnabledFeatures::slimmingPaintCompositorLayerizationEnabled())
42 return; 42 return;
43 43
44 if (m_graphicsContext.displayItemList()->displayItemConstructionIsDisabled() ) 44 if (m_graphicsContext.displayItemList()->displayItemConstructionIsDisabled() )
45 return; 45 return;
46 46
47 if (m_isFixedPositionContainer) { 47 if (m_isFixedPositionContainer) {
48 if (m_graphicsContext.displayItemList()->lastDisplayItemIsNoopBegin()) 48 if (m_graphicsContext.displayItemList()->lastDisplayItemIsNoopBegin())
49 m_graphicsContext.displayItemList()->removeLastDisplayItem(); 49 m_graphicsContext.displayItemList()->removeLastDisplayItem();
50 else 50 else
51 m_graphicsContext.displayItemList()->add(EndFixedPositionContainerDi splayItem::create(m_layoutObject)); 51 m_graphicsContext.displayItemList()->createAndAppend<EndFixedPositio nDisplayItem>(m_layoutObject);
52 } 52 }
53 53
54 if (m_isFixedPosition) { 54 if (m_isFixedPosition) {
55 if (m_graphicsContext.displayItemList()->lastDisplayItemIsNoopBegin()) 55 if (m_graphicsContext.displayItemList()->lastDisplayItemIsNoopBegin())
56 m_graphicsContext.displayItemList()->removeLastDisplayItem(); 56 m_graphicsContext.displayItemList()->removeLastDisplayItem();
57 else 57 else
58 m_graphicsContext.displayItemList()->add(EndFixedPositionDisplayItem ::create(m_layoutObject)); 58 m_graphicsContext.displayItemList()->createAndAppend<EndFixedPositio nDisplayItem>(m_layoutObject);
59 } 59 }
60 } 60 }
61 61
62 } // namespace blink 62 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/paint/LayerClipRecorderTest.cpp ('k') | Source/core/paint/LayoutObjectDrawingRecorderTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698