src/core/SkMaskFilter.cpp - Issue 119343003: Fast blurred rectangles on GPU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkMaskFilter.cpp

Issue 119343003: Fast blurred rectangles on GPU (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: handle null input color, and some comments from Brian Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkMaskFilter.cpp

diff --git a/src/core/SkMaskFilter.cpp b/src/core/SkMaskFilter.cpp

index f062f135fdbebbd4f5016bfde05dc0a424e04ccb..9bfd57f010965a8b9bb31d3250d93bd9046b71e7 100644

--- a/src/core/SkMaskFilter.cpp

+++ b/src/core/SkMaskFilter.cpp

@@ -309,6 +309,13 @@ bool SkMaskFilter::canFilterMaskGPU(const SkRect& devBounds,

return false;

}

+bool SkMaskFilter::directFilterMaskGPU(GrContext *context,

reed1 2014/01/02 17:32:39 minor nit: skia places the * or & with the type, n

humper 2014/01/02 18:12:10 Done -- someday I will train my fingers to type th

+ GrPaint *grp,

+ const SkStrokeRec& strokeRec,

+ const SkPath *path) const {

+ return false;

bool SkMaskFilter::filterMaskGPU(GrContext* context,

const SkBitmap& srcBM,

const SkRect& maskRect,