Issue 1193393002: Remove @NoSideEffects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1193393002: Remove @NoSideEffects (Closed)

Created:
5 years, 6 months ago by dgn

Modified:
5 years, 6 months ago

Reviewers:
Yaron

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove @NoSideEffects The annotation was deprecated. There is no usage left, we can remove this now. BUG=501221 Committed: https://crrev.com/6ed7449c544145ba986a5fbe2b572db8f0e65356 Cr-Commit-Position: refs/heads/master@{#336010}

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -19 lines)			Patch
	D	base/android/java/src/org/chromium/base/annotations/NoSideEffects.java	View		1 chunk	+0 lines, -18 lines	0 comments	Download
	M	chrome/android/java/proguard.flags	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1193393002/1

5 years, 6 months ago (2015-06-24 21:31:34 UTC) #5

commit-bot: I haz the power

5 years, 6 months ago (2015-06-24 22:01:35 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/6ed7449c544145ba986a5fbe2b572db8f0e65356
Cr-Commit-Position: refs/heads/master@{#336010}