Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Side by Side Diff: chrome/android/java/proguard.flags

Issue 1193393002: Remove @NoSideEffects (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/android/java/src/org/chromium/base/annotations/NoSideEffects.java ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Keep line number information, useful for stack traces. 1 # Keep line number information, useful for stack traces.
2 -keepattributes SourceFile,LineNumberTable 2 -keepattributes SourceFile,LineNumberTable
3 3
4 # Keep the annotations. 4 # Keep the annotations.
5 -keep @interface *** 5 -keep @interface ***
6 6
7 # Disable obfuscation for the following two packages. 7 # Disable obfuscation for the following two packages.
8 -keepnames class com.google.android.apps.chrome.**,org.chromium.** { 8 -keepnames class com.google.android.apps.chrome.**,org.chromium.** {
9 *; 9 *;
10 } 10 }
(...skipping 14 matching lines...) Expand all
25 @**.UsedByReflection <methods>; 25 @**.UsedByReflection <methods>;
26 @**.VisibleForTesting *; 26 @**.VisibleForTesting *;
27 native <methods>; 27 native <methods>;
28 } 28 }
29 29
30 # Keep all runtime visible annotations 30 # Keep all runtime visible annotations
31 -keepattributes RuntimeVisibleAnnotations 31 -keepattributes RuntimeVisibleAnnotations
32 32
33 # Remove methods annotated with this if their return value is unused 33 # Remove methods annotated with this if their return value is unused
34 -assumenosideeffects class * { 34 -assumenosideeffects class * {
35 @org.chromium.base.annotations.NoSideEffects <methods>;
36 @org.chromium.base.annotations.RemovableInRelease <methods>; 35 @org.chromium.base.annotations.RemovableInRelease <methods>;
37 } 36 }
38 37
39 # TODO(aurimas): figure out why we need to keep these classes. 38 # TODO(aurimas): figure out why we need to keep these classes.
40 -keep class org.chromium.base.test.** { 39 -keep class org.chromium.base.test.** {
41 *; 40 *;
42 } 41 }
43 42
44 # Keep protobuf code used via reflection 43 # Keep protobuf code used via reflection
45 # TODO(tonyg): Removing these -keeps results in new notes, but nothing seems to 44 # TODO(tonyg): Removing these -keeps results in new notes, but nothing seems to
(...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after
111 } 110 }
112 111
113 -keep class com.google.android.gms.cast.CastMediaControlIntent* { 112 -keep class com.google.android.gms.cast.CastMediaControlIntent* {
114 *; 113 *;
115 } 114 }
116 115
117 # fling is used by Android WebView and a Chrome test. 116 # fling is used by Android WebView and a Chrome test.
118 -keepclassmembers class org.chromium.content.browser.ContentViewCore { 117 -keepclassmembers class org.chromium.content.browser.ContentViewCore {
119 public void fling(long, int, int, int, int); 118 public void fling(long, int, int, int, int);
120 } 119 }
OLDNEW
« no previous file with comments | « base/android/java/src/org/chromium/base/annotations/NoSideEffects.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698