test/unittests/compiler/js-typed-lowering-unittest.cc - Issue 1193313002: Vector ICs: Additional Turbofan support

Unified Diff: test/unittests/compiler/js-typed-lowering-unittest.cc

Issue 1193313002: Vector ICs: Additional Turbofan support (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: REBASE. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/unittests/compiler/js-typed-lowering-unittest.cc

diff --git a/test/unittests/compiler/js-typed-lowering-unittest.cc b/test/unittests/compiler/js-typed-lowering-unittest.cc

index bb1198e13d5c766de0b5a9f83ccd456707b9a1e7..50c1734c0802be425e2b80843691d28d223dde05 100644

--- a/test/unittests/compiler/js-typed-lowering-unittest.cc

+++ b/test/unittests/compiler/js-typed-lowering-unittest.cc

@@ -736,13 +736,13 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArray) {

Node* base = HeapConstant(array);

Node* value =

Parameter(AccessBuilder::ForTypedArrayElement(type, true).type);

+ Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

VectorSlotPair feedback;

- Node* node =

- graph()->NewNode(javascript()->StoreProperty(language_mode, feedback),

- base, key, value, context);

+ const Operator* op = javascript()->StoreProperty(language_mode, feedback);

+ Node* node = graph()->NewNode(op, base, key, value, vector, context);

for (int i = 0;

i < OperatorProperties::GetFrameStateInputCount(node->op()); i++) {

node->AppendInput(zone(), EmptyFrameState());

@@ -784,13 +784,13 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithConversion) {

Type::Range(kMinInt / element_size, kMaxInt / element_size, zone()));

Node* base = HeapConstant(array);

Node* value = Parameter(Type::Any());

+ Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

VectorSlotPair feedback;

- Node* node =

- graph()->NewNode(javascript()->StoreProperty(language_mode, feedback),

- base, key, value, context);

+ const Operator* op = javascript()->StoreProperty(language_mode, feedback);

+ Node* node = graph()->NewNode(op, base, key, value, vector, context);

for (int i = 0;

i < OperatorProperties::GetFrameStateInputCount(node->op()); i++) {

node->AppendInput(zone(), EmptyFrameState());

@@ -845,13 +845,13 @@ TEST_F(JSTypedLoweringTest, JSStorePropertyToExternalTypedArrayWithSafeKey) {

Node* key = Parameter(Type::Range(min, max, zone()));

Node* base = HeapConstant(array);

Node* value = Parameter(access.type);

+ Node* vector = UndefinedConstant();

Node* context = UndefinedConstant();

Node* effect = graph()->start();

Node* control = graph()->start();

VectorSlotPair feedback;

- Node* node =

- graph()->NewNode(javascript()->StoreProperty(language_mode, feedback),

- base, key, value, context);

+ const Operator* op = javascript()->StoreProperty(language_mode, feedback);

+ Node* node = graph()->NewNode(op, base, key, value, vector, context);

for (int i = 0;

i < OperatorProperties::GetFrameStateInputCount(node->op()); i++) {

node->AppendInput(zone(), EmptyFrameState());

« no previous file with comments | « src/compiler/js-operator.cc ('k') | no next file » | no next file with comments »