Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4145)

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry.cc

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add test for IsSafeRedirectTarget Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/custom_handlers/protocol_handler_registry.cc
diff --git a/chrome/browser/custom_handlers/protocol_handler_registry.cc b/chrome/browser/custom_handlers/protocol_handler_registry.cc
index 3be1184aca68907c0e73f7439a13f5a28fc0837e..42436452a39fb6c7d6eb73064f3bbfcd3d102be7 100644
--- a/chrome/browser/custom_handlers/protocol_handler_registry.cc
+++ b/chrome/browser/custom_handlers/protocol_handler_registry.cc
@@ -205,6 +205,12 @@ bool ProtocolHandlerRegistry::JobInterceptorFactory::IsHandledURL(
job_factory_->IsHandledURL(url);
}
+bool ProtocolHandlerRegistry::JobInterceptorFactory::IsSafeRedirectTarget(
+ const GURL& location) const {
+ DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ return job_factory_->IsSafeRedirectTarget(location);
mmenke 2013/02/19 17:26:15 This seems weird to me. If io_thread_delegate_ ha
pauljensen 2013/02/20 15:13:27 So there are two ProtocolHandler classes and three
erikwright (departed) 2013/02/20 15:25:48 It is entirely reasonable to consider the Protocol
mmenke 2013/02/20 15:48:58 This all SGTM (Leaving it for another CL, separati
+}
+
// DefaultClientObserver ------------------------------------------------------
ProtocolHandlerRegistry::DefaultClientObserver::DefaultClientObserver(

Powered by Google App Engine
This is Rietveld 408576698