chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc - Issue 11931024: Removed static factories for data, ftp, file, and about jobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add test for IsSafeRedirectTarget Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/custom_handlers/protocol_handler_registry.cc ('K') | « chrome/browser/custom_handlers/protocol_handler_registry.cc ('k') | chrome/browser/extensions/api/web_request/web_request_api_unittest.cc » ('j') | content/browser/browser_plugin/browser_plugin_host_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

diff --git a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

index 283d66b082c1ade14a0e4b0851afcb705b617b6f..b6165cb84b2b6e35e17e23520321cbd8859aa755 100644

--- a/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

+++ b/chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

@@ -72,6 +72,9 @@ class FakeURLRequestJobFactory : public net::URLRequestJobFactory {

virtual bool IsHandledURL(const GURL& url) const OVERRIDE {

return false;

}

+ virtual bool IsSafeRedirectTarget(const GURL& location) const OVERRIDE {

+ return true;

+ }

};

void AssertWillHandleIO(