Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: net/url_request/url_request_ftp_job_unittest.cc

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address erikwright's comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_ftp_job_unittest.cc
diff --git a/net/url_request/url_request_ftp_job_unittest.cc b/net/url_request/url_request_ftp_job_unittest.cc
index e13a80d721745b7c857d1c41c6a3428e17708703..f1bb99056a6fabef81cbf5753bade13eb54eec8b 100644
--- a/net/url_request/url_request_ftp_job_unittest.cc
+++ b/net/url_request/url_request_ftp_job_unittest.cc
@@ -2,7 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "net/ftp/ftp_auth_cache.h"
#include "net/ftp/ftp_transaction.h"
#include "net/ftp/ftp_transaction_factory.h"
#include "net/url_request/ftp_protocol_handler.h"
@@ -50,14 +49,12 @@ TEST(FtpProtocolHandlerTest, CreateTransactionFails) {
::testing::StrictMock<MockFtpTransactionFactory> ftp_transaction_factory;
::testing::StrictMock<MockURLRequestDelegate> delegate;
- FtpAuthCache ftp_auth_cache;
GURL url("ftp://example.com");
URLRequestContext context;
URLRequest url_request(url, &delegate, &context);
- FtpProtocolHandler ftp_protocol_handler(
- &ftp_transaction_factory, &ftp_auth_cache);
+ FtpProtocolHandler ftp_protocol_handler(&ftp_transaction_factory);
scoped_refptr<URLRequestJob> ftp_job(
ftp_protocol_handler.MaybeCreateJob(&url_request, NULL));

Powered by Google App Engine
This is Rietveld 408576698