Removed static factories for data, ftp, file, and about jobs.

net/url_request/url_request_context_builder.h

Index: net/url_request/url_request_context_builder.h
diff --git a/net/url_request/url_request_context_builder.h b/net/url_request/url_request_context_builder.h
index fd21f8a62fe3a587017b08b9a5f998da6a519552..108076f8ce2b31c9e4436cd0579d3bab3b6e4844 100644
--- a/net/url_request/url_request_context_builder.h
+++ b/net/url_request/url_request_context_builder.h
@@ -85,11 +85,6 @@ class NET_EXPORT URLRequestContextBuilder {
     user_agent_ = user_agent;
   }
 
-  // By default it's disabled.
-  void set_ftp_enabled(bool enable) {

[mmenke, 2013/01/22 16:50:37]

Should we actually keep this, and create a job factory, with all the needed
protocol handlers (ftp, file, and data)?

Believe this class was created for external consumers, and this CL may break
them, if they depend on this class.

[willchan no longer on Chromium, 2013/01/23 17:14:55]

Minor obvious compile-time breakage is OK. They'll be able to figure it out.

I'd really like to avoid non-chromium devs from having to know how to
instantiate a URLRequestJobFactoryImpl. I'd like for them know to have to know
about it at all. They should be able to just use a setter in
URLRequestContextBuilder to have it create the appropriate URLRequestContext. I
think adding setters for file:// and data:// would be good too. It's not obvious
to me what the default should be, but I'd err on the side of leaving it off,
since I think most consumers just want a HTTP stack.

[pauljensen, 2013/01/23 21:43:33]

I added a URLRequestJobFactoryImpl with file, data and ftp ProtocolHandlers all
controlled via setters.

-    ftp_enabled_ = enable;
-  }
-
   // Uses BasicNetworkDelegate by default. Note that calling Build will unset
   // any custom delegate in builder, so this must be called each time before
   // Build is called.
@@ -118,7 +113,6 @@ class NET_EXPORT URLRequestContextBuilder {
   std::string accept_language_;
   std::string accept_charset_;
   std::string user_agent_;
-  bool ftp_enabled_;
   bool http_cache_enabled_;
   HttpCacheParams http_cache_params_;
   HttpNetworkSessionParams http_network_session_params_;