net/url_request/url_request_ftp_job.h - Issue 11931024: Removed static factories for data, ftp, file, and about jobs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/url_request/url_request_ftp_job.h

Issue 11931024: Removed static factories for data, ftp, file, and about jobs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address erikwright's comments Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/url_request/url_request_ftp_job.h

diff --git a/net/url_request/url_request_ftp_job.h b/net/url_request/url_request_ftp_job.h

index d05e3d892a87acf2aeef6038b81268bec514e2dc..63b2030d66019191c9df80545dd7ad269a7ee0de 100644

--- a/net/url_request/url_request_ftp_job.h

+++ b/net/url_request/url_request_ftp_job.h

@@ -29,11 +29,6 @@ class URLRequestFtpJob : public URLRequestJob {

FtpTransactionFactory* ftp_transaction_factory,

FtpAuthCache* ftp_auth_cache);

- // TODO(shalev): get rid of this function in favor of FtpProtocolHandler.

- static URLRequestJob* Factory(URLRequest* request,

- NetworkDelegate* network_delegate,

- const std::string& scheme);

// Overridden from URLRequestJob:

virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;

virtual HostPortPair GetSocketAddress() const OVERRIDE;