Removed static factories for data, ftp, file, and about jobs.

net/url_request/url_request_context_builder.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This class is useful for building a simple URLRequestContext. Most creators
 // of new URLRequestContexts should use this helper class to construct it. Call
 // any configuration params, and when done, invoke Build() to construct the
 // URLRequestContext. This URLRequestContext will own all its own storage.
 //
 // URLRequestContextBuilder and its associated params classes are initially
@@ skipping 67 matching lines @@
   void set_accept_language(const std::string& accept_language) {
     accept_language_ = accept_language;
   }
   void set_accept_charset(const std::string& accept_charset) {
     accept_charset_ = accept_charset;
   }
   void set_user_agent(const std::string& user_agent) {
     user_agent_ = user_agent;
   }
 
-  // By default it's disabled.
-  void set_ftp_enabled(bool enable) {

[mmenke, 2013/01/22 16:50:37]

Should we actually keep this, and create a job factory, with all the needed
protocol handlers (ftp, file, and data)?

Believe this class was created for external consumers, and this CL may break
them, if they depend on this class.

[willchan no longer on Chromium, 2013/01/23 17:14:55]

Minor obvious compile-time breakage is OK. They'll be able to figure it out.

I'd really like to avoid non-chromium devs from having to know how to
instantiate a URLRequestJobFactoryImpl. I'd like for them know to have to know
about it at all. They should be able to just use a setter in
URLRequestContextBuilder to have it create the appropriate URLRequestContext. I
think adding setters for file:// and data:// would be good too. It's not obvious
to me what the default should be, but I'd err on the side of leaving it off,
since I think most consumers just want a HTTP stack.

[pauljensen, 2013/01/23 21:43:33]

I added a URLRequestJobFactoryImpl with file, data and ftp ProtocolHandlers all
controlled via setters.

-    ftp_enabled_ = enable;
-  }
-
   // Uses BasicNetworkDelegate by default. Note that calling Build will unset
   // any custom delegate in builder, so this must be called each time before
   // Build is called.
   void set_network_delegate(NetworkDelegate* delegate) {
     network_delegate_.reset(delegate);
   }
 
   // By default HttpCache is enabled with a default constructed HttpCacheParams.
   void EnableHttpCache(const HttpCacheParams& params) {
     http_cache_params_ = params;
   }
 
   void DisableHttpCache() {
     http_cache_params_ = HttpCacheParams();
   }
 
   // Override default net::HttpNetworkSession::Params settings.
   void set_http_network_session_params(
       const HttpNetworkSessionParams& http_network_session_params) {
     http_network_session_params_ = http_network_session_params;
   }
 
   URLRequestContext* Build();
 
  private:
   std::string accept_language_;
   std::string accept_charset_;
   std::string user_agent_;
-  bool ftp_enabled_;
   bool http_cache_enabled_;
   HttpCacheParams http_cache_params_;
   HttpNetworkSessionParams http_network_session_params_;
 #if defined(OS_LINUX) || defined(OS_ANDROID)
   scoped_ptr<ProxyConfigService> proxy_config_service_;
 #endif  // defined(OS_LINUX) || defined(OS_ANDROID)
   scoped_ptr<NetworkDelegate> network_delegate_;
 
   DISALLOW_COPY_AND_ASSIGN(URLRequestContextBuilder);
 };
 
 }  // namespace net
 
 #endif  // NET_URL_REQUEST_URL_REQUEST_CONTEXT_BUILDER_H_