Small bugfix in test_suite.dart

tools/testing/dart/test_suite.dart

Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 2b3075f339034999ce80828266c2601b91e950c1..e7145babd6b1a262fb6600a592f922ff539fb208 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -971,8 +971,16 @@ class StandardTestSuite extends TestSuite {
             htmlPath.substring(basePath.length) : htmlPath;
         String fullHtmlPath = htmlPath;
         if (!htmlPath.startsWith('http')) {
-          fullHtmlPath = 'http://127.0.0.1:${serverList[0].port}$htmlPath?'
-              'crossOriginPort=${serverList[1].port}';
+          // Note: If we run test.py with the "--list" option, no http servers
+          // will be started.
+          var serverPort = "PORT";

[ahe, 2013/01/25 12:40:23]

It is kinda hard to understand how this works. Could you explain how this
prevents servers from starting?

[kustermann, 2013/01/28 11:20:54]

This doesn't prevent servers from starting. In tools/test.dart we check if
'--list' was passed. If so, we don't start http servers.

The issue is, that currently if we try to run
"tools/test.py .... --list html"
for example, test.dart crashes, because it tries to access
serverList[0]/serverList[1], but serverList is empty (since no http servers were
started).

The CL now replaces the port numbers with the symbolic names
"PORT/CROSS_ORIGIN_PORT" in case no http servers were started.

+          var crossOriginPort = "CROSS_ORIGIN_PORT";
+          if (!configuration['list']) {
+            serverPort = serverList[0].port;

[ricow1, 2013/01/24 14:06:14]

this is probably slightly messing up types, what about:
serverPort = serverList[0].port.toString();

[kustermann, 2013/01/28 11:20:54]

Done.

+            crossOriginPort = serverList[1].port;
+          }
+          fullHtmlPath = 'http://127.0.0.1:$serverPort$htmlPath?'
+              'crossOriginPort=$crossOriginPort';
         }
         if (info.optionsFromFile['isMultiHtmlTest']
             && subtestNames.length > 0) {