Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11929022: Small bugfix in test_suite.dart (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 96299ae2c4c79e8654738c9b67b2a981cfe96f74..790a96f18692306f954e33c86bb0088f143c1be5 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -971,8 +971,12 @@ class StandardTestSuite extends TestSuite {
htmlPath.substring(basePath.length) : htmlPath;
String fullHtmlPath = htmlPath;
if (!htmlPath.startsWith('http')) {
- fullHtmlPath = 'http://127.0.0.1:${serverList[0].port}$htmlPath?'
- 'crossOriginPort=${serverList[1].port}';
+ // Note: If we run test.py with the "--list" option, no http servers
+ // will be started. Therefore we need the following condition.
+ if (serverList.length >= 2) {
ricow1 2013/01/23 14:40:32 why not just check if we passed the list flag?
+ fullHtmlPath = 'http://127.0.0.1:${serverList[0].port}$htmlPath?'
+ 'crossOriginPort=${serverList[1].port}';
+ }
}
if (info.optionsFromFile['isMultiHtmlTest']
&& subtestNames.length > 0) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698