media/base/stream_parser_buffer.cc - Issue 11929015: Tighten up media::DecoderBuffer API contract for end of stream buffers (round 2).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/stream_parser_buffer.cc

Issue 11929015: Tighten up media::DecoderBuffer API contract for end of stream buffers (round 2). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/base/decoder_buffer_unittest.cc ('k') | media/filters/decrypting_audio_decoder.cc » ('j') | webkit/plugins/ppapi/content_decryptor_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/base/stream_parser_buffer.cc

diff --git a/media/base/stream_parser_buffer.cc b/media/base/stream_parser_buffer.cc

index 13e649e8595df8b152da7d51f159a75987886490..18143829d5c2ca9672bc339c2cd667a38a365dcd 100644

--- a/media/base/stream_parser_buffer.cc

+++ b/media/base/stream_parser_buffer.cc

@@ -35,7 +35,9 @@ StreamParserBuffer::StreamParserBuffer(const uint8* data, int data_size,

is_keyframe_(is_keyframe),

decode_timestamp_(kNoTimestamp()),

config_id_(kInvalidConfigId) {

- SetDuration(kNoTimestamp());

+ if (data) {

+ SetDuration(kNoTimestamp());

scherkus (not reviewing) 2013/01/26 00:14:44 I wonder if kNoTimestamp() should be the default v

xhwang 2013/01/28 16:35:20 Sounds good to me. But nothing says the default sh

scherkus (not reviewing) 2013/01/28 18:28:37 I'll add a TODO -- I *think* the reason why the ct

+ }

}

StreamParserBuffer::~StreamParserBuffer() {

« no previous file with comments | « media/base/decoder_buffer_unittest.cc ('k') | media/filters/decrypting_audio_decoder.cc » ('j') | webkit/plugins/ppapi/content_decryptor_delegate.cc » ('J')