Tighten up media::DecoderBuffer API contract for end of stream buffers (round 2).

media/base/stream_parser_buffer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/stream_parser_buffer.h"
 
 #include "base/logging.h"
 #include "media/base/buffers.h"
 
 namespace media {
@@ skipping 17 matching lines @@
 void StreamParserBuffer::SetDecodeTimestamp(const base::TimeDelta& timestamp) {
   decode_timestamp_ = timestamp;
 }
 
 StreamParserBuffer::StreamParserBuffer(const uint8* data, int data_size,
                                        bool is_keyframe)
     : DecoderBuffer(data, data_size),
       is_keyframe_(is_keyframe),
       decode_timestamp_(kNoTimestamp()),
       config_id_(kInvalidConfigId) {
-  SetDuration(kNoTimestamp());
+  if (data) {
+    SetDuration(kNoTimestamp());

[scherkus (not reviewing), 2013/01/26 00:14:44]

I wonder if kNoTimestamp() should be the default value in the superclass

Today it's zero, which is a valid (and common!) timestamp

[xhwang, 2013/01/28 16:35:20]

Sounds good to me. But nothing says the default should be invalid :) At least we
need to make the behavior of these two classes the same.

[scherkus (not reviewing), 2013/01/28 18:28:37]

I'll add a TODO -- I *think* the reason why the ctors don't force you to set
timestamp+duration is because we were commonly using DecoderBuffer(0) for EOS
buffers ... but that's no longer a concern

+  }
 }
 
 StreamParserBuffer::~StreamParserBuffer() {
 }
 
 int StreamParserBuffer::GetConfigId() const {
   return config_id_;
 }
 
 void StreamParserBuffer::SetConfigId(int config_id) {
   config_id_ = config_id;
 }
 
 }  // namespace media