extensions/renderer/v8_context_native_handler.cc - Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/v8_context_native_handler.cc

Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/v8_context_native_handler.cc

diff --git a/extensions/renderer/v8_context_native_handler.cc b/extensions/renderer/v8_context_native_handler.cc

index 6fbc8b246b37e16cfd3382bcdc24ec1f0169be5c..ed915cc423f717a1a5fb6ce04b96947e613db787 100644

--- a/extensions/renderer/v8_context_native_handler.cc

+++ b/extensions/renderer/v8_context_native_handler.cc

@@ -61,7 +61,7 @@ void V8ContextNativeHandler::RunWithNativesEnabledModuleSystem(

CHECK_EQ(args.Length(), 1);

CHECK(args[0]->IsFunction());

v8::Local<v8::Value> call_with_args[] = {

- context()->module_system()->NewInstance()};

+ context()->module_system()->NewInstance()};

ModuleSystem::NativesEnabledScope natives_enabled(context()->module_system());

context()->CallFunction(v8::Local<v8::Function>::Cast(args[0]), 1,

call_with_args);