extensions/renderer/utils_native_handler.cc - Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/utils_native_handler.cc

Issue 1192763002: extensions: Use V8 Maybe APIs in NativeHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/utils_native_handler.cc

diff --git a/extensions/renderer/utils_native_handler.cc b/extensions/renderer/utils_native_handler.cc

index 209069cb942d3fd74b96a63c0351b3835d5087d7..49ff32ad7eae12bd2f0c5a80017d935681a6c443 100644

--- a/extensions/renderer/utils_native_handler.cc

+++ b/extensions/renderer/utils_native_handler.cc

@@ -62,6 +62,7 @@ void UtilsNativeHandler::CreateClassWrapper(

// TODO(fsamuel): Move privates from ModuleSystem to a shared location.

v8::Local<v8::Object> natives(context()->module_system()->NewInstance());

CHECK(!natives.IsEmpty()); // this can happen if v8 has issues

v8::Local<v8::Function> func = func_as_value.As<v8::Function>();

v8::Local<v8::Value> func_args[] = {

context()->safe_builtins()->GetObjekt(),