fpdfsdk/src/fpdf_dataavail.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/fpdf_dataavail.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/fpdf_dataavail.cpp

diff --git a/fpdfsdk/src/fpdf_dataavail.cpp b/fpdfsdk/src/fpdf_dataavail.cpp

index b6363a882774a4fa61ec6e775953373660993f04..b26d2af10afc5c9be716908e67d8f23002a84091 100644

--- a/fpdfsdk/src/fpdf_dataavail.cpp

+++ b/fpdfsdk/src/fpdf_dataavail.cpp

@@ -87,7 +87,7 @@ public:

~CFPDF_DataAvail()

{

- if (m_pDataAvail) delete m_pDataAvail;

+ delete m_pDataAvail;

}

IPDF_DataAvail* m_pDataAvail;

@@ -106,8 +106,7 @@ DLLEXPORT FPDF_AVAIL STDCALL FPDFAvail_Create(FX_FILEAVAIL* file_avail, FPDF_FIL

DLLEXPORT void STDCALL FPDFAvail_Destroy(FPDF_AVAIL avail)

{

- if (avail == NULL) return;

- delete (CFPDF_DataAvail*)avail;

+ delete (CFPDF_DataAvail*)avail;

}

DLLEXPORT int STDCALL FPDFAvail_IsDocAvail(FPDF_AVAIL avail, FX_DOWNLOADHINTS* hints)

« no previous file with comments | « fpdfsdk/src/formfiller/FFL_IFormFiller.cpp ('k') | fpdfsdk/src/fpdfview.cpp » ('j') | no next file with comments »