fpdfsdk/src/formfiller/FFL_IFormFiller.cpp - Issue 1192743004: Cleanup: Do not check pointers before deleting them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/formfiller/FFL_IFormFiller.cpp

Issue 1192743004: Cleanup: Do not check pointers before deleting them. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/src/formfiller/FFL_IFormFiller.cpp

diff --git a/fpdfsdk/src/formfiller/FFL_IFormFiller.cpp b/fpdfsdk/src/formfiller/FFL_IFormFiller.cpp

index 9969c18b63771dccf4791e4e7ba710de7a02ee5e..464ff3ce6b1c1ea24f34873bdf90631d6d9320f8 100644

--- a/fpdfsdk/src/formfiller/FFL_IFormFiller.cpp

+++ b/fpdfsdk/src/formfiller/FFL_IFormFiller.cpp

@@ -704,14 +704,11 @@ void CFFL_IFormFiller::RemoveFormFiller(CPDFSDK_Annot* pAnnot)

void CFFL_IFormFiller::UnRegisterFormFiller(CPDFSDK_Annot* pAnnot)

{

- CFFL_FormFiller * pFormFiller = NULL;

- if (m_Maps.Lookup(pAnnot,pFormFiller))

- {

- if (pFormFiller)

- delete pFormFiller;

- m_Maps.RemoveKey(pAnnot);

- }

+ CFFL_FormFiller* pFormFiller = nullptr;

+ if (m_Maps.Lookup(pAnnot,pFormFiller)) {

+ delete pFormFiller;

+ m_Maps.RemoveKey(pAnnot);

+ }

}

void CFFL_IFormFiller::SetFocusAnnotTab(CPDFSDK_Annot* pWidget, FX_BOOL bSameField, FX_BOOL bNext)

« no previous file with comments | « core/src/fxge/win32/fx_win32_print.cpp ('k') | fpdfsdk/src/fpdf_dataavail.cpp » ('j') | no next file with comments »