Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 1192663002: Implement support for CHROMIUM_path_rendering pseudo extension (Closed)

Created:
5 years, 6 months ago by Kimmo Kinnunen
Modified:
5 years ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@chromium-pathrendering-prepare-03
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Implement support for CHROMIUM_path_rendering pseudo extension Implement support for path rendering in Chromium through CHROMIUM_path_rendering pseudo extension. The extension defines a new pseudo-gl function, BindFragmentInputLocation. This behaves similarly to the BindUniformLocation pseudo-gl function. The idea is to assign fragment input location to a fragment input before linking the program. BUG=chromium:344330 Committed: https://skia.googlesource.com/skia/+/eeef46d181f9f8db388ecea81df699fc1b3c9280 Committed: https://skia.googlesource.com/skia/+/6bb6d4075b198c5935ab6f2d71364ca7ff0153d1

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -5 lines) Patch
M include/gpu/gl/GrGLFunctions.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M include/gpu/gl/GrGLInterface.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLCaps.cpp View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLInterface.cpp View 1 2 3 3 chunks +7 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLPathRendering.h View 3 chunks +12 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLPathRendering.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLPathProgramBuilder.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLPathProgramBuilder.cpp View 1 2 3 1 chunk +17 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (6 generated)
Kimmo Kinnunen
This is the patch I wanted to implement with the recent uploads. It'd help a ...
5 years, 6 months ago (2015-06-18 11:58:41 UTC) #2
bsalomon
lgtm
5 years, 6 months ago (2015-06-18 14:40:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192663002/60001
5 years, 5 months ago (2015-07-02 09:54:18 UTC) #6
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-02 09:54:19 UTC) #7
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-02 10:01:26 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/eeef46d181f9f8db388ecea81df699fc1b3c9280
5 years, 5 months ago (2015-07-02 10:01:47 UTC) #9
jvanverth1
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1223673002/ by jvanverth@google.com. ...
5 years, 5 months ago (2015-07-02 19:53:06 UTC) #10
Kimmo Kinnunen
This was reverted. Reversion did not fix the deps problem. Ok to retry?
5 years, 5 months ago (2015-07-13 07:05:22 UTC) #11
Kimmo Kinnunen
On 2015/07/13 07:05:22, Kimmo Kinnunen wrote: > This was reverted. Reversion did not fix the ...
5 years, 5 months ago (2015-07-13 12:09:40 UTC) #12
bsalomon
On 2015/07/13 12:09:40, Kimmo Kinnunen wrote: > On 2015/07/13 07:05:22, Kimmo Kinnunen wrote: > > ...
5 years, 5 months ago (2015-07-14 13:52:17 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1192663002/80001
5 years, 5 months ago (2015-07-14 13:52:31 UTC) #16
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 13:52:32 UTC) #17
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 14:01:43 UTC) #18
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 14:31:42 UTC) #19
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 15:02:01 UTC) #20
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 15:31:47 UTC) #21
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 16:01:51 UTC) #22
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 16:31:58 UTC) #23
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 17:02:15 UTC) #24
commit-bot: I haz the power
The author kkinnunen@nvidia.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
5 years, 5 months ago (2015-07-14 17:32:08 UTC) #25
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 17:59:26 UTC) #26
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/6bb6d4075b198c5935ab6f2d71364ca7ff0153d1

Powered by Google App Engine
This is Rietveld 408576698