Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(15)

Issue 1192633003: content: Rename raster threads to worker threads.

Created:
5 years, 7 months ago by reveman
Modified:
5 years, 7 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, creis+watch_chromium.org, danakj+watch_chromium.org, darin-cc_chromium.org, davemoore+watch_chromium.org, dzhioev+watch_chromium.org, jam, jbauman+watch_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, sievers+watch_chromium.org, stevenjb+watch_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content: Rename raster threads to worker threads. This in preparation for using these threads for more than raster. BUG=348979 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -90 lines) Patch
M cc/test/test_task_graph_runner.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/browser/about_flags.cc View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/view_manager/gles2/raster_thread_helper.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M content/browser/gpu/compositor_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/gpu/compositor_util.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 6 chunks +28 lines, -30 lines 0 comments Download
M tools/perf/metrics/timeline.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
reveman
5 years, 7 months ago (2015-06-18 01:20:51 UTC) #2
Avi (use Gerrit)
"Worker thread" is incredibly generic. I know you're going to do more than raster on ...
5 years, 7 months ago (2015-06-18 01:35:38 UTC) #3
reveman
On 2015/06/18 at 01:35:38, avi wrote: > "Worker thread" is incredibly generic. I know you're ...
5 years, 7 months ago (2015-06-18 03:02:53 UTC) #4
Avi (use Gerrit)
On 2015/06/18 03:02:53, reveman wrote: > On 2015/06/18 at 01:35:38, avi wrote: > > "Worker ...
5 years, 7 months ago (2015-06-18 03:51:22 UTC) #5
reveman
On 2015/06/18 at 03:51:22, avi wrote: > On 2015/06/18 03:02:53, reveman wrote: > > On ...
5 years, 7 months ago (2015-06-18 13:34:27 UTC) #6
Avi (use Gerrit)
On 2015/06/18 13:34:27, reveman wrote: > On 2015/06/18 at 03:51:22, avi wrote: > > On ...
5 years, 7 months ago (2015-06-18 14:28:16 UTC) #7
reveman
On 2015/06/18 at 14:28:16, avi wrote: > On 2015/06/18 13:34:27, reveman wrote: > > On ...
5 years, 7 months ago (2015-06-18 14:48:47 UTC) #8
Avi (use Gerrit)
5 years, 7 months ago (2015-06-18 14:51:10 UTC) #9
On 2015/06/18 14:48:47, reveman wrote:
> On 2015/06/18 at 14:28:16, avi wrote:
> > On 2015/06/18 13:34:27, reveman wrote:
> > > On 2015/06/18 at 03:51:22, avi wrote:
> > > > On 2015/06/18 03:02:53, reveman wrote:
> > > > > On 2015/06/18 at 01:35:38, avi wrote:
> > > > > > "Worker thread" is incredibly generic. I know you're going to do
more
> than
> > > > > raster on them, but are they still going to be doing graphics work?
> > > > > > 
> > > > > > Can we have "graphics worker thread" or "graphics thread"?
> > > > > 
> > > > > The use-cases I'm aware of are copying of video frames in media and
> decoding
> > > of
> > > > > fav-icons but I know that scheduler folks are interested in using this
> for
> > > more.
> > > > > I'll find out what these additional use-cases are and get back to you.
> > > > > 
> > > > > However, the general idea is that we should not have a different set
of
> > > worker
> > > > > threads for each type of tasks but instead one set of worker threads
> that
> > > all
> > > > > parts of a chrome process can share. This would allow us to better
> control
> > > the
> > > > > number of threads we use and make it easier to implement more advanced
> > > control
> > > > > such as dynamically adjusting the number of worker threads based on if
a
> > > process
> > > > > is doing background work or has visible widgets.
> > > > 
> > > > But don't we already have a thread pool?
> > > 
> > > We have base::WorkerPool but it doesn't provide the task dependencies and
> > > ability to cancel and re-prioritize tasks that is required by the raster
> system.
> > > It would be nice to just have one thread pool eventually. It should be
> possible
> > > to implement base::WorkerPool on top of the more advanced TaskGraphRunner
> > > interface used by what we currently call "raster"-threads.
> > 
> > OK, but we can't have "worker threads" and "base::WorkerPool" and not expect
> confusion. Until we do that unification, we need some kind of name
> differentiation.
> 
> Makes sense. Ignore this patch for now. We'll just use "raster" for lack of
> better name until we've been able to unify all worker threads.

If you want, you can add some kind of note to the class comment, saying that the
threads are used for more than just rasterizing.

Powered by Google App Engine
This is Rietveld 408576698