Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(223)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/api_test/usb/invalid_length_transfer/manifest.json
Issue
11926005
:
Fix transfer length validation in Usb Api. (Closed)
Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set:
Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/extensions/api/usb/usb_api.cc
chrome/browser/extensions/api/usb/usb_apitest.cc
chrome/test/data/extensions/api_test/usb/invalid_length_transfer/manifest.json
chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/extensions/api/usb/usb_apitest.cc
('k') |
chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
{
2
"name": "USB Invalid-Length Transfer",
3
"version": "0.1",
4
"app": {
5
"background": {
6
"scripts": ["test.js"]
7
}
8
},
9
"permissions": [
10
"usb"
11
]
12
}
OLD
NEW
« no previous file with comments
|
« chrome/browser/extensions/api/usb/usb_apitest.cc
('k') |
chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js »
('j') |
no next file with comments »
Issue 11926005: Fix transfer length validation in Usb Api. (Closed)
Created 7 years, 11 months ago by meacer
Modified 7 years, 11 months ago
Reviewers: Garret Kelly, miket_OOO
Base URL: https://src.chromium.org/chrome/trunk/src/
Comments: 2
This is Rietveld
408576698