Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 11926005: Fix transfer length validation in Usb Api. (Closed)

Created:
7 years, 11 months ago by meacer
Modified:
7 years, 11 months ago
Reviewers:
miket_OOO, Garret Kelly
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
https://src.chromium.org/chrome/trunk/src/
Visibility:
Public.

Description

Fix transfer length validation in Usb Api. This change limits the length parameter of Usb transfers to 0-100 MB. It introduces a new error for invalid transfer lengths. It also correctly ignores 'data' parameter if transfer 'direction' equals 'in', and ignores transfer 'length' parameter if 'direction' is 'out'. BUG=169972, 169981 TEST=browser_tests: UsbApiTest.InvalidLengthTransfer TBR=gdk@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177857

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -22 lines) Patch
M chrome/browser/extensions/api/usb/usb_api.cc View 1 2 9 chunks +56 lines, -22 lines 0 comments Download
M chrome/browser/extensions/api/usb/usb_apitest.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/usb/invalid_length_transfer/manifest.json View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js View 1 2 1 chunk +53 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
meacer
+gdk, miket for review
7 years, 11 months ago (2013-01-18 18:43:16 UTC) #1
miket_OOO
lgtm https://codereview.chromium.org/11926005/diff/5001/chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js File chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js (right): https://codereview.chromium.org/11926005/diff/5001/chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js#newcode28 chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js:28: var largeSize = 100*1024*1024 + 1; whitespace around ...
7 years, 11 months ago (2013-01-18 20:39:03 UTC) #2
meacer
https://codereview.chromium.org/11926005/diff/5001/chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js File chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js (right): https://codereview.chromium.org/11926005/diff/5001/chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js#newcode28 chrome/test/data/extensions/api_test/usb/invalid_length_transfer/test.js:28: var largeSize = 100*1024*1024 + 1; On 2013/01/18 20:39:03, ...
7 years, 11 months ago (2013-01-18 22:48:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/11926005/8003
7 years, 11 months ago (2013-01-19 02:14:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/meacer@chromium.org/11926005/8003
7 years, 11 months ago (2013-01-19 02:28:44 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-20 00:38:17 UTC) #6
Message was sent while issue was closed.
Change committed as 177857

Powered by Google App Engine
This is Rietveld 408576698